pkg/browser/lib/interop.js - Issue 25138003: Cache the context proxy. Don't use window for global 'this'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/browser/lib/interop.js

Issue 25138003: Cache the context proxy. Don't use window for global 'this'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/browser/lib/interop.js

diff --git a/pkg/browser/lib/interop.js b/pkg/browser/lib/interop.js

index 40e1700ad76d53fe7d69ec4819c10387678d1789..8577e4f28b8c30aa67270ff78727da5789d0bea0 100644

--- a/pkg/browser/lib/interop.js

+++ b/pkg/browser/lib/interop.js

@@ -224,7 +224,9 @@ function DartProxy(o) {

(function() {

// Proxy support for js.dart.

- var globalContext = window;

+ // We don't use 'window' because we might be in a web worker, but we don't

+ // use 'self' because not all browsers support it

+ var globalContext = function() { return this; }();

// Table for local objects and functions that are proxied.

function ProxiedObjectTable() {

« no previous file with comments | « no previous file | sdk/lib/_internal/lib/isolate_helper.dart » ('j') | no next file with comments »