sdk/lib/_internal/lib/isolate_helper.dart - Issue 25138003: Cache the context proxy. Don't use window for global 'this'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/isolate_helper.dart

Issue 25138003: Cache the context proxy. Don't use window for global 'this'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/isolate_helper.dart

diff --git a/sdk/lib/_internal/lib/isolate_helper.dart b/sdk/lib/_internal/lib/isolate_helper.dart

index ac4cc0f87211e3792329a71ec6ac285a545d0faa..8b0ad62a9b2a8a245f6367322bb0991617b03f41 100644

--- a/sdk/lib/_internal/lib/isolate_helper.dart

+++ b/sdk/lib/_internal/lib/isolate_helper.dart

@@ -411,7 +411,7 @@ class _MainManagerStub {

const String _SPAWNED_SIGNAL = "spawned";

-var globalThis = IsolateNatives.computeGlobalThis();

+var globalThis = Primitives.computeGlobalThis();

var globalWindow = JS('', "#.window", globalThis);

var globalWorker = JS('', "#.Worker", globalThis);

bool globalPostMessageDefined =

@@ -480,8 +480,6 @@ class IsolateNatives {

throw new UnsupportedError('Cannot extract URI from "$stack"');

}

- static computeGlobalThis() => JS('', 'function() { return this; }()');

/**

* Assume that [e] is a browser message event and extract its message data.

* We don't import the dom explicitly so, when workers are disabled, this

« no previous file with comments | « pkg/browser/lib/interop.js ('k') | sdk/lib/_internal/lib/js_helper.dart » ('j') | no next file with comments »