Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2513553002: Loading: split MockFontResourceClient from MockResourceClients (Closed)

Created:
4 years, 1 month ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
tkent, hiroshige, yhirano
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: split MockFontResourceClient from MockResourceClients To remove additional dependency from core/fetch/ to FontResource, split MockFontResourceClient from MockResourceClients, and place it under core/loader/resource/. BUG=655920

Patch Set 1 #

Total comments: 4

Patch Set 2 : review #6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -67 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MockResourceClients.h View 2 chunks +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MockResourceClients.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.cpp View 1 chunk +40 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (11 generated)
Takashi Toyoshima
Since Shao's CL introduced one more dependency from core/fetch to FontResource, let me submit this ...
4 years, 1 month ago (2016-11-17 07:26:25 UTC) #5
yhirano
lgtm https://codereview.chromium.org/2513553002/diff/1/third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h File third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h (right): https://codereview.chromium.org/2513553002/diff/1/third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h#newcode8 third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h:8: #include "core/fetch/FontResource.h" #include "core/fetch/Resource.h" https://codereview.chromium.org/2513553002/diff/1/third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h#newcode9 third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h:9: #include "platform/heap/Handle.h" ...
4 years, 1 month ago (2016-11-17 07:30:48 UTC) #6
hiroshige
lgtm
4 years, 1 month ago (2016-11-17 09:05:56 UTC) #7
Takashi Toyoshima
https://codereview.chromium.org/2513553002/diff/1/third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h File third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h (right): https://codereview.chromium.org/2513553002/diff/1/third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h#newcode8 third_party/WebKit/Source/core/loader/resource/MockFontResourceClient.h:8: #include "core/fetch/FontResource.h" On 2016/11/17 07:30:48, yhirano wrote: > #include ...
4 years, 1 month ago (2016-11-17 10:18:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513553002/20001
4 years, 1 month ago (2016-11-17 10:18:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/306807)
4 years, 1 month ago (2016-11-17 10:25:54 UTC) #15
Takashi Toyoshima
+tkent for BUILD.gn again
4 years, 1 month ago (2016-11-17 10:26:59 UTC) #17
tkent
lgtm
4 years, 1 month ago (2016-11-17 22:24:04 UTC) #18
Takashi Toyoshima
4 years ago (2016-11-29 07:43:22 UTC) #20
Sorry for being lazy to handle this patch, but I'm finally back from P1 bug
shooting.
Since the CL that this patch tried to fix was reverted, I'd just close this.

Powered by Google App Engine
This is Rietveld 408576698