Loading: split tests depend on FontResource to loader/resource/FontResourceTest

Loading: split tests depend on FontResource to loader/resource/FontResourceTest

This patch splits a test that depends on FontResource to another test
file, loader/resource/FontResourceTest.

FontResource will follow this patch to be moved into loader/resource/.

BUG=655920
Committed: https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6
Cr-Commit-Position: refs/heads/master@{#432800}

[Takashi Toyoshima, 2016-11-16 08:09:08]

Description was changed from

==========
Loading: split tests depend on FontResource to loader/resource/FontResourceTest

This patch splits a test that depends on FontResource to another test
file, loader/resource/FontResourceTest.

FontResource will follow this patch to be moved into loader/resource/.

BUG=655920
==========

to

==========
Loading: split tests depend on FontResource to loader/resource/FontResourceTest

This patch splits a test that depends on FontResource to another test
file, loader/resource/FontResourceTest.

FontResource will follow this patch to be moved into loader/resource/.

BUG=655920
==========

[Takashi Toyoshima, 2016-11-16 08:09:08]

toyoshim@chromium.org changed reviewers:
+ hiroshige@chromium.org, yhirano@chromium.org

[Takashi Toyoshima, 2016-11-16 08:10:11]

This depends on https://codereview.chromium.org/2497463004/ that is still
stacked in CQ, but could you start review?

[Takashi Toyoshima, 2016-11-16 10:17:48]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 10:18:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-11-16 10:19:27]

ok, now the depending CL was landed.
Patch Set 3 was mechanically rebased one, and I need to modify it to follow
Shao's cache-aware loading change.

Please take a look at the Patch Set 4.

[commit-bot: I haz the power, 2016-11-16 13:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 13:13:48]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[hiroshige, 2016-11-17 06:05:11]

lgtm

[yhirano, 2016-11-17 06:41:34]

lgtm

[Takashi Toyoshima, 2016-11-17 06:51:15]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-11-17 06:51:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 07:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 07:00:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Takashi Toyoshima, 2016-11-17 07:21:58]

toyoshim@chromium.org changed reviewers:
+ tkent@chromium.org

[Takashi Toyoshima, 2016-11-17 07:22:09]

+tkent for BUILD.gn

[tkent, 2016-11-17 07:24:18]

lgtm

[Takashi Toyoshima, 2016-11-17 07:26:47]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-11-17 07:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 07:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 07:33:28]

Failed to apply patch for third_party/WebKit/Source/core/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/BUILD.gn:1259
  error: third_party/WebKit/Source/core/BUILD.gn: patch does not apply

Patch:       third_party/WebKit/Source/core/BUILD.gn
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn
b/third_party/WebKit/Source/core/BUILD.gn
index
84e90d61d185d6919c4d2027edca7236fc354456..b58f2f1cc43d46363120c007772c1c95da77cd21
100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -1259,6 +1259,7 @@ source_set("unit_tests") {
     "loader/ProgressTrackerTest.cpp",
     "loader/TextResourceDecoderBuilderTest.cpp",
     "loader/ThreadableLoaderTest.cpp",
+    "loader/resource/FontResourceTest.cpp",
     "origin_trials/OriginTrialContextTest.cpp",
     "page/ChromeClientTest.cpp",
     "page/ContextMenuControllerTest.cpp",

[commit-bot: I haz the power, 2016-11-17 07:34:37]

Description was changed from

==========
Loading: split tests depend on FontResource to loader/resource/FontResourceTest

This patch splits a test that depends on FontResource to another test
file, loader/resource/FontResourceTest.

FontResource will follow this patch to be moved into loader/resource/.

BUG=655920
==========

to

==========
Loading: split tests depend on FontResource to loader/resource/FontResourceTest

This patch splits a test that depends on FontResource to another test
file, loader/resource/FontResourceTest.

FontResource will follow this patch to be moved into loader/resource/.

BUG=655920

Committed: https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6
Cr-Commit-Position: refs/heads/master@{#432800}
==========

[commit-bot: I haz the power, 2016-11-17 07:34:38]

Patchset 4 (id:??) landed as
https://crrev.com/95739c0f46d7ba1eaa74833531c45dd0121c3cd6
Cr-Commit-Position: refs/heads/master@{#432800}