Removed ordering dependencies for ECursor

Removed ordering dependencies for ECursor

Removed ordering dependencies for ECursor from CSSValueKeywords.h. Also
modified the ordering of the ECursor keywords to ensure the ordering
does not affect tests.

BUG=665272
Committed: https://crrev.com/bb9efc255043a3cd727ca7d46f072bc639e4585c
Cr-Commit-Position: refs/heads/master@{#433482}

[sashab, 2016-11-17 03:52:35]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 03:53:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-17 04:47:22]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:30:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alancutter (OOO until 2018), 2016-11-17 06:18:55]

lgtm with nits.

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right):

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1198: return
ECursor::Auto;
This can be moved to the default case, no need for break.

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSValueKeywords.in (left):

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSValueKeywords.in:397: all-scroll
We should maintain the order between this list and the code code for
convenience. It's harder to check if something's missing otherwise.

[sashab, 2016-11-21 03:27:58]

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right):

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:1198: return
ECursor::Auto;
On 2016/11/17 at 06:18:55, alancutter wrote:
> This can be moved to the default case, no need for break.

Done, will update style of others to match too (although this will be generated
so probably Ok to leave)

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSValueKeywords.in (left):

https://codereview.chromium.org/2513523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSValueKeywords.in:397: all-scroll
On 2016/11/17 at 06:18:55, alancutter wrote:
> We should maintain the order between this list and the code code for
convenience. It's harder to check if something's missing otherwise.

Good point :) We can test this properly when we generate them, since the order
will be actually random. In the meantime I'll try test it locally with a
randomly ordered file but then revert it before uploading the patch.

[sashab, 2016-11-21 03:28:00]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-11-21 03:28:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2513523002/#ps20001
(title: "Removed reordering")

[commit-bot: I haz the power, 2016-11-21 03:28:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 06:23:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479698880765990,
"parent_rev": ["887e5b5d9f6cb81cf3f20a38f0a18ec0ac1b1231", null], "commit_rev":
["c0ace9e8a577367ed6eb228261495625ace0d46d", null]}

[commit-bot: I haz the power, 2016-11-21 06:23:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 06:26:09]

Description was changed from

==========
Removed ordering dependencies for ECursor

Removed ordering dependencies for ECursor from CSSValueKeywords.h. Also
modified the ordering of the ECursor keywords to ensure the ordering
does not affect tests.

BUG=665272
==========

to

==========
Removed ordering dependencies for ECursor

Removed ordering dependencies for ECursor from CSSValueKeywords.h. Also
modified the ordering of the ECursor keywords to ensure the ordering
does not affect tests.

BUG=665272

Committed: https://crrev.com/bb9efc255043a3cd727ca7d46f072bc639e4585c
Cr-Commit-Position: refs/heads/master@{#433482}
==========

[commit-bot: I haz the power, 2016-11-21 06:26:10]

Patchset 2 (id:??) landed as
https://crrev.com/bb9efc255043a3cd727ca7d46f072bc639e4585c
Cr-Commit-Position: refs/heads/master@{#433482}