Removed ordering dependencies for ECursor

third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

 /*
  * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ skipping 1098 matching lines @@
       break;
     case ECursor::WebkitGrabbing:
       m_valueID = CSSValueWebkitGrabbing;
       break;
   }
 }
 
 template <>
 inline ECursor CSSIdentifierValue::convertTo() const {
   switch (m_valueID) {
+    case CSSValueAuto:
+      return ECursor::Auto;
+    case CSSValueCrosshair:
+      return ECursor::Cross;
+    case CSSValueDefault:
+      return ECursor::Default;
+    case CSSValuePointer:
+      return ECursor::Pointer;
+    case CSSValueMove:
+      return ECursor::Move;
+    case CSSValueCell:
+      return ECursor::Cell;
+    case CSSValueVerticalText:
+      return ECursor::VerticalText;
+    case CSSValueContextMenu:
+      return ECursor::ContextMenu;
+    case CSSValueAlias:
+      return ECursor::Alias;
     case CSSValueCopy:
       return ECursor::Copy;
+    case CSSValueNone:
+      return ECursor::None;
+    case CSSValueProgress:
+      return ECursor::Progress;
+    case CSSValueNoDrop:
+      return ECursor::NoDrop;
+    case CSSValueNotAllowed:
+      return ECursor::NotAllowed;
+    case CSSValueZoomIn:
     case CSSValueWebkitZoomIn:
       return ECursor::ZoomIn;
+    case CSSValueZoomOut:
     case CSSValueWebkitZoomOut:
       return ECursor::ZoomOut;
-    case CSSValueNone:
-      return ECursor::None;
+    case CSSValueEResize:
+      return ECursor::EResize;
+    case CSSValueNeResize:
+      return ECursor::NeResize;
+    case CSSValueNwResize:
+      return ECursor::NwResize;
+    case CSSValueNResize:
+      return ECursor::NResize;
+    case CSSValueSeResize:
+      return ECursor::SeResize;
+    case CSSValueSwResize:
+      return ECursor::SwResize;
+    case CSSValueSResize:
+      return ECursor::SResize;
+    case CSSValueWResize:
+      return ECursor::WResize;
+    case CSSValueEwResize:
+      return ECursor::EwResize;
+    case CSSValueNsResize:
+      return ECursor::NsResize;
+    case CSSValueNeswResize:
+      return ECursor::NeswResize;
+    case CSSValueNwseResize:
+      return ECursor::NwseResize;
+    case CSSValueColResize:
+      return ECursor::ColResize;
+    case CSSValueRowResize:
+      return ECursor::RowResize;
+    case CSSValueText:
+      return ECursor::Text;
+    case CSSValueWait:
+      return ECursor::Wait;
+    case CSSValueHelp:
+      return ECursor::Help;
+    case CSSValueAllScroll:
+      return ECursor::AllScroll;
+    case CSSValueWebkitGrab:
+      return ECursor::WebkitGrab;
+    case CSSValueWebkitGrabbing:
+      return ECursor::WebkitGrabbing;
     default:
-      return static_cast<ECursor>(m_valueID - CSSValueAuto);
+      break;
   }
+
+  NOTREACHED();
+  return ECursor::Auto;

[alancutter (OOO until 2018), 2016/11/17 06:18:55]

This can be moved to the default case, no need for break.

[sashab, 2016/11/21 03:27:57]

Done, will update style of others to match too (although this will be generated
so probably Ok to leave)

 }
 
 template <>
 inline CSSIdentifierValue::CSSIdentifierValue(EDisplay e)
     : CSSValue(IdentifierClass) {
   switch (e) {
     case EDisplay::Inline:
       m_valueID = CSSValueInline;
       break;
     case EDisplay::Block:
@@ skipping 3523 matching lines @@
     default:
       break;
   }
   ASSERT_NOT_REACHED();
   return ContainsNone;
 }
 
 }  // namespace blink
 
 #endif