third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness (Closed)

Patch Set: address CL feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test-helper.js ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector-unit/trie.js ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

index c986ba7614b3a5811281018af44422403d34993e..1c58fcf346b1642a36349c261fd12a4dff3d2088 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -791,6 +791,8 @@ class Port(object):

else:

path_in_wpt = filename

return self._manifest_items_for_path(path_in_wpt) is not None

+ if 'inspector-unit' in dirname:

dgozman 2016/11/28 18:44:51 No idea whether this is a correct place to do a ch

+ return filesystem.splitext(filename)[1] == '.js' and 'helper.js' not in filename

return Port._has_supported_extension(

filesystem, filename) and not Port.is_reference_html_file(filesystem, dirname, filename)