third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py - Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness (Closed)

Patch Set: address CL feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

index 36d4dd32b694b1500aa88873fe635c077563682f..26545fc3fc9c12764e968a70ed7db3e1411e2763 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

@@ -355,6 +355,10 @@ class PortTest(unittest.TestCase):

self.assertTrue(is_test_file('', 'foo.html'))

self.assertTrue(is_test_file('', 'foo.svg'))

self.assertTrue(is_test_file('', 'test-ref-test.html'))

+ self.assertTrue(is_test_file('inspector-unit', 'trie.js'))

+ self.assertFalse(is_test_file('inspector-unit', 'foo.html'))

+ self.assertFalse(is_test_file('inspector-unit', 'trie-helper.js'))

+ self.assertFalse(is_test_file('inspector', 'devtools.js'))

self.assertFalse(is_test_file('', 'foo.png'))

self.assertFalse(is_test_file('', 'foo-expected.html'))

self.assertFalse(is_test_file('', 'foo-expected.svg'))