DevTools: Convert inspector-unit tests to use reusable test harness

components/test_runner/test_interfaces.cc

Index: components/test_runner/test_interfaces.cc
diff --git a/components/test_runner/test_interfaces.cc b/components/test_runner/test_interfaces.cc
index e5f0c0762b1bf9dc8272b4d79616ec75425ba7b2..3e3e715664004ce57d92d09d82253ab3844af4be 100644
--- a/components/test_runner/test_interfaces.cc
+++ b/components/test_runner/test_interfaces.cc
@@ -96,7 +96,8 @@ void TestInterfaces::ConfigureForTestWithURL(const blink::WebURL& test_url,
   if (spec.find("/inspector/") != std::string::npos ||
       spec.find("/inspector-enabled/") != std::string::npos)
     test_runner_->ClearDevToolsLocalStorage();
-  if (spec.find("/inspector/") != std::string::npos) {
+  if (spec.find("/inspector/") != std::string::npos &&
+      spec.find("unit_test_runner.html") == std::string::npos) {

[dgozman, 2016/11/30 18:19:54]

Why this? How does the url for unit_test_runner.html look?

[einbinder, 2016/11/30 19:51:06]

Shouldn't unit_test_runner.html be under a /front_end/ folder not an /inspector/
folder?

[chenwilliam, 2016/11/30 19:53:08]

I added this because the unit_test_runner app file is served from
"/resources/inspector".

file:///.../chromium/src/out/Release/resources/inspector/unit_test_runner.html?experiments=true&test=http://localhost:8080/inspector-unit/test-failure.js

[einbinder, 2016/12/01 02:07:51]

Nice!

     // Subfolder name determines default panel to open.
     std::string test_path = spec.substr(spec.find("/inspector/") + 11);
     base::DictionaryValue settings;