DevTools: Convert inspector-unit tests to use reusable test harness

third_party/WebKit/Source/devtools/front_end/externs.js

Index: third_party/WebKit/Source/devtools/front_end/externs.js
diff --git a/third_party/WebKit/Source/devtools/front_end/externs.js b/third_party/WebKit/Source/devtools/front_end/externs.js
index ce5dd2e324a988bb66deaa3d99f8dc20024f02f3..acd501443aa5bc567d1aa8e69b4a4fa4f5df9c9f 100644
--- a/third_party/WebKit/Source/devtools/front_end/externs.js
+++ b/third_party/WebKit/Source/devtools/front_end/externs.js
@@ -806,6 +806,9 @@ Terminal.prototype = {
   on: function(eventName, handler) {}
 };
 
+var testRunner = {};

[einbinder, 2016/11/30 19:51:06]

Can we somehow enforce that this might be undefined? I'm worried about a
situation where someone uses testRunner before checking if it exists, all the
tests on the bots pass, but it breaks devtools or at least the tests outside of
content shell.

[chenwilliam, 2016/11/30 23:06:03]

I moved the type definition into the test_runner module so it's a closure type
error if you use self.testRunner in a production module. It's still possible to
break tests outside of content shell (when we write them in the future) but I
think we can address this later once we have them.

+testRunner.notifyDone = function() {};
+
 // Module namespaces.
 var Accessibility = {};
 var Animation = {};
@@ -840,10 +843,12 @@ var SDK = {};
 var Security = {};
 var Services = {};
 var Settings = {};
+var Shell = {};
 var Snippets = {};
 var SourceFrame = {};
 var Sources = {};
 var Terminal = {};
+var TestRunner = {};
 var TextEditor = {};
 var Timeline = {};
 var TimelineModel = {};