third_party/WebKit/Source/core/fetch/Resource.h - Issue 2513413008: [ImageResource 0a] Do not notify ResourceClient/ImageResourceObserver of finish twice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2513413008: [ImageResource 0a] Do not notify ResourceClient/ImageResourceObserver of finish twice (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index aa2cbc8f9a7c556d361e4acf17368fa54556bda6..b0c154d00a5ac4ac27bb680ff779b5a0ffc6588f 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -338,8 +338,7 @@ class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource>,

virtual void checkNotify();

- enum class MarkFinishedOption { ShouldMarkFinished, DoNotMarkFinished };

- void notifyClientsInternal(MarkFinishedOption);

yhirano 2016/11/29 02:23:30 Is it a good idea to merge this function to checkN

hiroshige 2016/11/29 07:54:31 Done.

+ void notifyClientsInternal();

void markClientFinished(ResourceClient*);

virtual bool hasClientsOrObservers() const {