Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2513413004: Remove isIconGenerated parameter from WebApkInfo (Closed)

Created:
4 years, 1 month ago by pkotwicz
Modified:
4 years, 1 month ago
Reviewers:
dominickn, Xi Han
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove isIconGenerated parameter from WebApkInfo WebAPK icons are never generated. WebAPK creation fails if the icon supplied in the Web Manifest is deficient. BUG=659845 Committed: https://crrev.com/edaf18481223e889c230ae9ddbe68d38290982ef Cr-Commit-Position: refs/heads/master@{#434011}

Patch Set 1 #

Patch Set 2 : Merge branch 'update_fail_refactor002' into update_fail_refactor003 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
Xi, can you please take a look?
4 years, 1 month ago (2016-11-21 19:37:56 UTC) #2
Xi Han
lgtm
4 years, 1 month ago (2016-11-21 19:44:28 UTC) #3
pkotwicz
Dominick for OWNERS
4 years, 1 month ago (2016-11-21 19:45:09 UTC) #5
dominickn
lgtm
4 years, 1 month ago (2016-11-21 22:51:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513413004/20001
4 years, 1 month ago (2016-11-22 22:18:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 22:53:19 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 22:55:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edaf18481223e889c230ae9ddbe68d38290982ef
Cr-Commit-Position: refs/heads/master@{#434011}

Powered by Google App Engine
This is Rietveld 408576698