chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java - Issue 2513413004: Remove isIconGenerated parameter from WebApkInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java

Issue 2513413004: Remove isIconGenerated parameter from WebApkInfo (Closed)

Patch Set: Merge branch 'update_fail_refactor002' into update_fail_refactor003 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java

index 25fe53e50cf4b4959ed347ac71428e04515d72dd..b58ea5c53d0df979359e12df15a9a1622c4c69d7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java

@@ -54,8 +54,7 @@ public class WebApkMetaDataUtils {

return WebApkInfo.create(WebApkConstants.WEBAPK_ID_PREFIX + webApkPackageName, url,

metaData.scope, encodedIcon, metaData.name, metaData.shortName,

metaData.displayMode, metaData.orientation, source, metaData.themeColor,

- metaData.backgroundColor, metaData.iconUrlAndIconMurmur2HashMap.isEmpty(),

- webApkPackageName);

+ metaData.backgroundColor, webApkPackageName);

}

/**