Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issue 2513393004: Fix bug in service worker push tests: don't cache subscription options (Closed)

Created:
4 years, 1 month ago by johnme
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix bug in service worker push tests: don't cache subscription options - This bug meant that calling workerSubscribeNoKey after workerSubscribe would actually subscribe with the cached key instead of no key. - This meant that some tests in PushMessagingBrowserTest were not testing exactly what they intended to test, prior to this patch. BUG= Review-Url: https://codereview.chromium.org/2449963002 Cr-Commit-Position: refs/heads/master@{#428108} (cherry picked from commit db15f2e4e890234356aaa82befafb0efb917cd20) Merge approval: https://crbug.com/659230#c25 Committed: https://chromium.googlesource.com/chromium/src/+/d49d16d7d503c10d4bb12de178bc54d6af1efdce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/test/data/push_messaging/service_worker.js View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
4 years, 1 month ago (2016-11-21 13:56:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d49d16d7d503c10d4bb12de178bc54d6af1efdce.

Powered by Google App Engine
This is Rietveld 408576698