Fix bug in service worker push tests: don't cache subscription options

Fix bug in service worker push tests: don't cache subscription options

- This bug meant that calling workerSubscribeNoKey after workerSubscribe
would actually subscribe with the cached key instead of no key.
- This meant that some tests in PushMessagingBrowserTest were not
testing exactly what they intended to test, prior to this patch.

BUG=

Committed: https://crrev.com/db15f2e4e890234356aaa82befafb0efb917cd20
Cr-Commit-Position: refs/heads/master@{#428108}

[awdf, 2016-10-25 15:56:24]

awdf@chromium.org changed reviewers:
+ johnme@chromium.org

[awdf, 2016-10-25 15:56:25]

As noticed when debugging with johnme@!

Decided to put this in a separate cl as it's kinda unrelated.

[awdf, 2016-10-25 15:57:13]

The CQ bit was checked by awdf@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 15:57:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 16:50:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 16:50:26]

Dry run: This issue passed the CQ dry run.

[awdf, 2016-10-27 17:06:46]

Description was changed from

==========
Fix bug in service worker push tests: don't cache subscription options

- This bug meant that calling workerSubscribeNoKey after workerSubscribe
would actually subscribe with the cached key instead of no key.
- This meant that some tests in PushMessagingBrowserTest were not
testing exactly what they intended to test, prior to this patch.

BUG=
==========

to

==========
Fix bug in service worker push tests: don't cache subscription options

- This bug meant that calling workerSubscribeNoKey after workerSubscribe
would actually subscribe with the cached key instead of no key.
- This meant that some tests in PushMessagingBrowserTest were not
testing exactly what they intended to test, prior to this patch.

BUG=
==========

[awdf, 2016-10-27 17:06:46]

awdf@chromium.org changed reviewers:
+ peter@chromium.org
- johnme@chromium.org

[awdf, 2016-10-27 17:08:41]

+peter@ for review

It might be nice to get this in before
https://codereview.chromium.org/2452833004 un-suppresses the
PushMessagingBrowserTests for chromeOS & linux.

It also blocks https://bugs.chromium.org/p/chromium/issues/detail?id=659230
right now

[Peter Beverloo, 2016-10-27 17:17:59]

lgtm

https://codereview.chromium.org/2449963002/diff/1/chrome/test/data/push_messa...
File chrome/test/data/push_messaging/service_worker.js (right):

https://codereview.chromium.org/2449963002/diff/1/chrome/test/data/push_messa...
chrome/test/data/push_messaging/service_worker.js:47: userVisibleOnly: true
nit: please use 4 space indent for dictionary values. May also want to
s/var/let/ while you're here.

[awdf, 2016-10-27 17:34:39]

https://codereview.chromium.org/2449963002/diff/1/chrome/test/data/push_messa...
File chrome/test/data/push_messaging/service_worker.js (right):

https://codereview.chromium.org/2449963002/diff/1/chrome/test/data/push_messa...
chrome/test/data/push_messaging/service_worker.js:47: userVisibleOnly: true
On 2016/10/27 17:17:59, Peter Beverloo wrote:
> nit: please use 4 space indent for dictionary values. May also want to
> s/var/let/ while you're here.

Done.

[awdf, 2016-10-27 17:34:44]

The CQ bit was checked by awdf@chromium.org

[awdf, 2016-10-27 17:34:45]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2449963002/#ps20001
(title: "Fix bug in sw push tests: stop caching subscription options between
messages")

[commit-bot: I haz the power, 2016-10-27 17:35:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:21:11]

Description was changed from

==========
Fix bug in service worker push tests: don't cache subscription options

- This bug meant that calling workerSubscribeNoKey after workerSubscribe
would actually subscribe with the cached key instead of no key.
- This meant that some tests in PushMessagingBrowserTest were not
testing exactly what they intended to test, prior to this patch.

BUG=
==========

to

==========
Fix bug in service worker push tests: don't cache subscription options

- This bug meant that calling workerSubscribeNoKey after workerSubscribe
would actually subscribe with the cached key instead of no key.
- This meant that some tests in PushMessagingBrowserTest were not
testing exactly what they intended to test, prior to this patch.

BUG=
==========

[commit-bot: I haz the power, 2016-10-27 19:21:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 19:32:45]

Description was changed from

==========
Fix bug in service worker push tests: don't cache subscription options

- This bug meant that calling workerSubscribeNoKey after workerSubscribe
would actually subscribe with the cached key instead of no key.
- This meant that some tests in PushMessagingBrowserTest were not
testing exactly what they intended to test, prior to this patch.

BUG=
==========

to

==========
Fix bug in service worker push tests: don't cache subscription options

- This bug meant that calling workerSubscribeNoKey after workerSubscribe
would actually subscribe with the cached key instead of no key.
- This meant that some tests in PushMessagingBrowserTest were not
testing exactly what they intended to test, prior to this patch.

BUG=

Committed: https://crrev.com/db15f2e4e890234356aaa82befafb0efb917cd20
Cr-Commit-Position: refs/heads/master@{#428108}
==========

[commit-bot: I haz the power, 2016-10-27 19:32:46]

Patchset 2 (id:??) landed as
https://crrev.com/db15f2e4e890234356aaa82befafb0efb917cd20
Cr-Commit-Position: refs/heads/master@{#428108}