Chromium Code Reviews
DescriptionRevert of Extracting placeholder information from Webkit to Blimp (patchset #15 id:280001 of https://codereview.chromium.org/2370393002/ )
Reason for revert:
I'm speculatively reverting this to see if it causes the failure in blink_platform_unittests noted in https://crbug.com/667094 and as seen in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20123
. It's not at all obvious to my why this would cause that failure, but it's not obvious to me what other changes would've, either, unless maybe it was pdr's change (which I will try if this doesn't fix it).
Original issue's description:
> Extracting placeholder information from Webkit to Blimp
>
> For text input, the new Blimp IME requires few additional information
> associated with the text field such as label and placeholder attributes.
> For a mock UI, visit go/blimp-type-3
>
> In this CL, the Blimp tab makes a call to RenderFrameHost to access
> the information about the currently focused text input field and
> supplies a callback to act upon obtaining the information. The
> RenderFrame gets the information, populates it into a FormFieldData
> struct and passes it to the browser which then invokes the supplied
> callback by the embedder.
>
> BUG=651902
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031
> Cr-Commit-Position: refs/heads/master@{#433364}
TBR=creis@chromium.org,ekaramad@chromium.org,dtrainor@chromium.org,nyquist@chromium.org,shuchen@chromium.org,tkent@chromium.org,kenrb@chromium.org,shaktisahu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=651902
Committed: https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320
Cr-Commit-Position: refs/heads/master@{#433460}
Patch Set 1 #Messages
Total messages: 13 (6 generated)
|