Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2513333002: Revert of Extracting placeholder information from Webkit to Blimp (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extracting placeholder information from Webkit to Blimp (patchset #15 id:280001 of https://codereview.chromium.org/2370393002/ ) Reason for revert: I'm speculatively reverting this to see if it causes the failure in blink_platform_unittests noted in https://crbug.com/667094 and as seen in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20123 . It's not at all obvious to my why this would cause that failure, but it's not obvious to me what other changes would've, either, unless maybe it was pdr's change (which I will try if this doesn't fix it). Original issue's description: > Extracting placeholder information from Webkit to Blimp > > For text input, the new Blimp IME requires few additional information > associated with the text field such as label and placeholder attributes. > For a mock UI, visit go/blimp-type-3 > > In this CL, the Blimp tab makes a call to RenderFrameHost to access > the information about the currently focused text input field and > supplies a callback to act upon obtaining the information. The > RenderFrame gets the information, populates it into a FormFieldData > struct and passes it to the browser which then invokes the supplied > callback by the embedder. > > BUG=651902 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/aacf8d1d11beaff516bd79f88b8571eae0f5d031 > Cr-Commit-Position: refs/heads/master@{#433364} TBR=creis@chromium.org,ekaramad@chromium.org,dtrainor@chromium.org,nyquist@chromium.org,shuchen@chromium.org,tkent@chromium.org,kenrb@chromium.org,shaktisahu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651902 Committed: https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320 Cr-Commit-Position: refs/heads/master@{#433460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -299 lines) Patch
M blimp/engine/feature/engine_render_widget_feature.h View 2 chunks +1 line, -2 lines 0 comments Download
M blimp/engine/feature/engine_render_widget_feature.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M blimp/engine/feature/engine_render_widget_feature_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M blimp/engine/session/blimp_engine_session.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M blimp/engine/session/tab.h View 3 chunks +0 lines, -14 lines 0 comments Download
M blimp/engine/session/tab.cc View 3 chunks +1 line, -39 lines 0 comments Download
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 4 chunks +0 lines, -99 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 5 chunks +0 lines, -27 lines 0 comments Download
M content/common/frame_messages.h View 4 chunks +0 lines, -17 lines 0 comments Download
M content/public/browser/render_frame_host.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/common/form_field_data.h View 1 chunk +0 lines, -28 lines 0 comments Download
D content/public/common/form_field_data.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Dirk Pranke
Created Revert of Extracting placeholder information from Webkit to Blimp
4 years, 1 month ago (2016-11-20 19:55:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513333002/1
4 years, 1 month ago (2016-11-20 19:56:01 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/71674)
4 years, 1 month ago (2016-11-20 21:19:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513333002/1
4 years, 1 month ago (2016-11-20 21:49:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-20 22:28:00 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fa9428f0ee39451a7c8c4f1386d20949bede4320 Cr-Commit-Position: refs/heads/master@{#433460}
4 years, 1 month ago (2016-11-20 22:30:35 UTC) #12
Dirk Pranke
4 years, 1 month ago (2016-11-21 17:44:32 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2520013002/ by dpranke@chromium.org.

The reason for reverting is: The revert did not fix the problem, so I'm
relanding this now.

See also crbug.com/667147..

Powered by Google App Engine
This is Rietveld 408576698