Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: blimp/engine/session/blimp_engine_session.cc

Issue 2513333002: Revert of Extracting placeholder information from Webkit to Blimp (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/feature/engine_render_widget_feature_unittest.cc ('k') | blimp/engine/session/tab.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/session/blimp_engine_session.cc
diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc
index f71ae27f15c1570a9c0dce82f533d7f202203d95..aee2e39dcccd3944fc1ecd4a08eeeeb323cbdcfe 100644
--- a/blimp/engine/session/blimp_engine_session.cc
+++ b/blimp/engine/session/blimp_engine_session.cc
@@ -421,11 +421,14 @@
ui::TextInputType type =
client ? client->GetTextInputType() : ui::TEXT_INPUT_TYPE_NONE;
+ // TODO(shaktisahu): Propagate the new type to the client.
// Hide IME, when text input is out of focus, i.e. if the text input type
// changes to ui::TEXT_INPUT_TYPE_NONE. For other text input types,
// OnShowImeIfNeeded is used instead to send show IME request to client.
if (type == ui::TEXT_INPUT_TYPE_NONE)
- tab_->HideTextInputUI();
+ render_widget_feature_.SendHideImeRequest(
+ tab_->tab_id(),
+ tab_->web_contents()->GetRenderWidgetHostView()->GetRenderWidgetHost());
}
void BlimpEngineSession::OnInputMethodDestroyed(
@@ -438,7 +441,10 @@
!window_tree_host_->GetInputMethod()->GetTextInputClient())
return;
- tab_->ShowTextInputUI();
+ render_widget_feature_.SendShowImeRequest(
+ tab_->tab_id(),
+ tab_->web_contents()->GetRenderWidgetHostView()->GetRenderWidgetHost(),
+ window_tree_host_->GetInputMethod()->GetTextInputClient());
}
void BlimpEngineSession::ProcessMessage(
« no previous file with comments | « blimp/engine/feature/engine_render_widget_feature_unittest.cc ('k') | blimp/engine/session/tab.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698