content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java - Issue 2513203002: Calling clearSelection instead of unselect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2513203002: Calling clearSelection instead of unselect (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

index cc9f0239684934013718186be805d5ffde80dfbd..77138e8e1d14e9f73ce25a742e91adc076c79871 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

@@ -551,7 +551,7 @@ public class SelectionPopupController extends ActionModeCallbackHelper {

mActionMode = null;

if (mUnselectAllOnDismiss) {

mWebContents.dismissTextHandles();

- mWebContents.unselect();

+ clearSelection();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »