Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2513163002: Add unittest that sandbox::PolicyBase outlives child process. (Closed)

Created:
4 years, 1 month ago by jbauman
Modified:
4 years ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org, rickyz+watch_chromium.org, forshaw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unittest that sandbox::PolicyBase outlives child process. BUG=663019 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/7d47e639710463d061bb385e60d8395161958284 Cr-Commit-Position: refs/heads/master@{#434778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M sandbox/win/src/policy_target_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M sandbox/win/tests/common/controller.h View 2 chunks +5 lines, -0 lines 0 comments Download
M sandbox/win/tests/common/controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jbauman
4 years, 1 month ago (2016-11-19 00:15:57 UTC) #7
Will Harris
lgtm
4 years ago (2016-11-23 16:45:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513163002/1
4 years ago (2016-11-23 22:21:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-24 00:24:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513163002/1
4 years ago (2016-11-28 22:03:28 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 23:41:59 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-28 23:43:37 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d47e639710463d061bb385e60d8395161958284
Cr-Commit-Position: refs/heads/master@{#434778}

Powered by Google App Engine
This is Rietveld 408576698