Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Unified Diff: sandbox/win/tests/common/controller.cc

Issue 2513163002: Add unittest that sandbox::PolicyBase outlives child process. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/tests/common/controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/tests/common/controller.cc
diff --git a/sandbox/win/tests/common/controller.cc b/sandbox/win/tests/common/controller.cc
index 9f57137c0e7d31844d75addb1590bd7080f6c476..6e45e0ef6c5ac78a41797133f5a58580b5fbb03c 100644
--- a/sandbox/win/tests/common/controller.cc
+++ b/sandbox/win/tests/common/controller.cc
@@ -242,6 +242,10 @@ int TestRunner::InternalRunTest(const wchar_t* command) {
result = broker_->SpawnTarget(prog_name, arguments.c_str(), policy_,
&warning_result, &last_error, &target);
}
+ if (release_policy_in_run_) {
+ policy_->Release();
+ policy_ = nullptr;
+ }
if (SBOX_ALL_OK != result)
return SBOX_TEST_FAILED_TO_RUN_TEST;
« no previous file with comments | « sandbox/win/tests/common/controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698