Fix double-free in displaySource API

Fix double-free in displaySource API

BUG=666803
R=dcheng@chromium.org

Committed: https://crrev.com/c2136443f59b89b66bb21cb58c389e5331b801f0
Cr-Commit-Position: refs/heads/master@{#433802}

[Ken Rockot(use gerrit already), 2016-11-19 02:02:00]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 02:02:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-19 02:10:49]

I opted for a dangling new because I don't like my StrongBindingPtr pattern at
all. I'm going to upload another CL to experiment with a new idea to address the
same bug, but WDYT of this?

[commit-bot: I haz the power, 2016-11-19 02:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 02:12:04]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-11-19 04:28:37]

On 2016/11/19 02:10:49, Ken Rockot wrote:
> I opted for a dangling new because I don't like my StrongBindingPtr pattern at
> all. I'm going to upload another CL to experiment with a new idea to address
the
> same bug, but WDYT of this?

I think in the past, people didn't really like the naked new pattern.

FWIW, I think that:

auto* impl = new Impl;
impl->binding = mojo::MakeStrongBinding(base::WrapUnique(impl),
std::move(request));

doesn't seem that bad: it's potentially even shorter than the version that uses
a lambda.

[Ken Rockot(use gerrit already), 2016-11-21 16:48:34]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 16:49:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-21 16:50:17]

It's not clear to me if this API is even actively used right now, but just in
case; here's the patch as you suggested. It's simple and thus easy to merge if
necessary.

[commit-bot: I haz the power, 2016-11-21 16:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 16:58:01]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-11-21 17:32:41]

lgtm

[Ken Rockot(use gerrit already), 2016-11-22 06:44:10]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-11-22 06:44:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 06:47:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479797050203780,
"parent_rev": "6a46c8c12eae55d580f8dee8cb4b61735b391d2b", "commit_rev":
"b79946a200786bd056364212312dd3ef2d690b40"}

[commit-bot: I haz the power, 2016-11-22 06:47:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 06:50:20]

Description was changed from

==========
Fix double-free in displaySource API

BUG=666803
R=dcheng@chromium.org
==========

to

==========
Fix double-free in displaySource API

BUG=666803
R=dcheng@chromium.org

Committed: https://crrev.com/c2136443f59b89b66bb21cb58c389e5331b801f0
Cr-Commit-Position: refs/heads/master@{#433802}
==========

[commit-bot: I haz the power, 2016-11-22 06:50:21]

Patchset 2 (id:??) landed as
https://crrev.com/c2136443f59b89b66bb21cb58c389e5331b801f0
Cr-Commit-Position: refs/heads/master@{#433802}