extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h - Issue 2513053003: Fix double-free in displaySource API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h

Issue 2513053003: Fix double-free in displaySource API (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc ('k') | extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h

diff --git a/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h b/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h

index 4a8e333dae311b87a68570e6f5310667d3ded01d..49749d720047747d1fabe9627b823bc431917130 100644

--- a/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h

+++ b/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.h

@@ -9,6 +9,7 @@

#include "extensions/browser/api/display_source/display_source_connection_delegate.h"

#include "extensions/common/mojo/wifi_display_session_service.mojom.h"

#include "mojo/public/cpp/bindings/interface_request.h"

+#include "mojo/public/cpp/bindings/strong_binding.h"

namespace content {

class BrowserContext;

@@ -62,6 +63,7 @@ class WiFiDisplaySessionServiceImpl

// Id of the sink of the session this object is associated with.

int sink_id_;

+ mojo::StrongBindingPtr<WiFiDisplaySessionService> binding_;

base::WeakPtrFactory<WiFiDisplaySessionServiceImpl> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(WiFiDisplaySessionServiceImpl);