Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2512943002: [crankshaft] The array protector is a PropertyCell, not a Cell. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] The array protector is a PropertyCell, not a Cell. There's a typo in a couple of lithium backends, where we assume that the array protector on the Isolate is a Cell instead of a PropertyCell. This could lead to unnecessary deoptimizations. R=yangguo@chromium.org Committed: https://crrev.com/30db83a3b596d2c1d3390e0f924c15e6f958a328 Cr-Commit-Position: refs/heads/master@{#41096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-18 10:44:35 UTC) #1
Yang
lgtm
4 years, 1 month ago (2016-11-18 10:49:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512943002/1
4 years, 1 month ago (2016-11-18 10:49:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 11:09:55 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 11:10:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30db83a3b596d2c1d3390e0f924c15e6f958a328
Cr-Commit-Position: refs/heads/master@{#41096}

Powered by Google App Engine
This is Rietveld 408576698