Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: src/crankshaft/mips64/lithium-codegen-mips64.cc

Issue 2512943002: [crankshaft] The array protector is a PropertyCell, not a Cell. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/mips/lithium-codegen-mips.cc ('k') | src/crankshaft/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/mips64/lithium-codegen-mips64.h" 5 #include "src/crankshaft/mips64/lithium-codegen-mips64.h"
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/crankshaft/hydrogen-osr.h" 9 #include "src/crankshaft/hydrogen-osr.h"
10 #include "src/crankshaft/mips64/lithium-gap-resolver-mips64.h" 10 #include "src/crankshaft/mips64/lithium-gap-resolver-mips64.h"
(...skipping 2958 matching lines...) Expand 10 before | Expand all | Expand 10 after
2969 DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS); 2969 DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS);
2970 Label done; 2970 Label done;
2971 __ LoadRoot(scratch, Heap::kTheHoleValueRootIndex); 2971 __ LoadRoot(scratch, Heap::kTheHoleValueRootIndex);
2972 __ Branch(&done, ne, result, Operand(scratch)); 2972 __ Branch(&done, ne, result, Operand(scratch));
2973 if (info()->IsStub()) { 2973 if (info()->IsStub()) {
2974 // A stub can safely convert the hole to undefined only if the array 2974 // A stub can safely convert the hole to undefined only if the array
2975 // protector cell contains (Smi) Isolate::kProtectorValid. Otherwise 2975 // protector cell contains (Smi) Isolate::kProtectorValid. Otherwise
2976 // it needs to bail out. 2976 // it needs to bail out.
2977 __ LoadRoot(result, Heap::kArrayProtectorRootIndex); 2977 __ LoadRoot(result, Heap::kArrayProtectorRootIndex);
2978 // The comparison only needs LS bits of value, which is a smi. 2978 // The comparison only needs LS bits of value, which is a smi.
2979 __ ld(result, FieldMemOperand(result, Cell::kValueOffset)); 2979 __ ld(result, FieldMemOperand(result, PropertyCell::kValueOffset));
2980 DeoptimizeIf(ne, instr, DeoptimizeReason::kHole, result, 2980 DeoptimizeIf(ne, instr, DeoptimizeReason::kHole, result,
2981 Operand(Smi::FromInt(Isolate::kProtectorValid))); 2981 Operand(Smi::FromInt(Isolate::kProtectorValid)));
2982 } 2982 }
2983 __ LoadRoot(result, Heap::kUndefinedValueRootIndex); 2983 __ LoadRoot(result, Heap::kUndefinedValueRootIndex);
2984 __ bind(&done); 2984 __ bind(&done);
2985 } 2985 }
2986 } 2986 }
2987 2987
2988 2988
2989 void LCodeGen::DoLoadKeyed(LLoadKeyed* instr) { 2989 void LCodeGen::DoLoadKeyed(LLoadKeyed* instr) {
(...skipping 2631 matching lines...) Expand 10 before | Expand all | Expand 10 after
5621 __ ld(result, FieldMemOperand(scratch, 5621 __ ld(result, FieldMemOperand(scratch,
5622 FixedArray::kHeaderSize - kPointerSize)); 5622 FixedArray::kHeaderSize - kPointerSize));
5623 __ bind(deferred->exit()); 5623 __ bind(deferred->exit());
5624 __ bind(&done); 5624 __ bind(&done);
5625 } 5625 }
5626 5626
5627 #undef __ 5627 #undef __
5628 5628
5629 } // namespace internal 5629 } // namespace internal
5630 } // namespace v8 5630 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/mips/lithium-codegen-mips.cc ('k') | src/crankshaft/ppc/lithium-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698