Archive icudtl.dat in ChromeOS continuous builds.

Archive icudtl.dat in ChromeOS continuous builds.

Also remove obsolete file entires and sort the list a bit more.

BUG=666448
Committed: https://crrev.com/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda
Cr-Commit-Position: refs/heads/master@{#432997}

[Lei Zhang, 2016-11-17 20:26:58]

thestig@chromium.org changed reviewers:
+ abodenha@chromium.org, mmoss@chromium.org

[Lei Zhang, 2016-11-17 20:27:00]

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
File chrome/tools/build/chromeos/FILES.cfg (left):

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
chrome/tools/build/chromeos/FILES.cfg:44: 'filename': 'chrome_sandbox',
Not built/used on ChromeOS.

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
chrome/tools/build/chromeos/FILES.cfg:52: 'filename': 'emit_login_prompt_ready',
I don't know what this is, but it doesn't exist.

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
chrome/tools/build/chromeos/FILES.cfg:84: 'filename': 'session',
Ditto.

[Lei Zhang, 2016-11-17 20:27:02]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 20:28:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Moss, 2016-11-17 20:49:29]

lgtm

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
File chrome/tools/build/chromeos/FILES.cfg (left):

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
chrome/tools/build/chromeos/FILES.cfg:44: 'filename': 'chrome_sandbox',
On 2016/11/17 20:27:00, Lei Zhang (Mostly OOO) wrote:
> Not built/used on ChromeOS.

Why wasn't archiving failing due to "not found"? Is that check disabled on the
chromeos builders?

[commit-bot: I haz the power, 2016-11-17 21:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:19:03]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-17 21:37:10]

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
File chrome/tools/build/chromeos/FILES.cfg (left):

https://codereview.chromium.org/2512763002/diff/1/chrome/tools/build/chromeos...
chrome/tools/build/chromeos/FILES.cfg:44: 'filename': 'chrome_sandbox',
On 2016/11/17 20:49:29, Michael Moss wrote:
> On 2016/11/17 20:27:00, Lei Zhang (Mostly OOO) wrote:
> > Not built/used on ChromeOS.
> 
> Why wasn't archiving failing due to "not found"? Is that check disabled on the
> chromeos builders?

Not sure. I only see warnings, which is how I a came up with the list to remove.

See the bottom and look for "WARNING:"

https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/28742/steps...
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

[Lei Zhang, 2016-11-17 21:45:59]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:47:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Moss, 2016-11-17 21:54:28]

> Not sure. I only see warnings, which is how I a came up with the list to
remove.
> 
> See the bottom and look for "WARNING:"

Yeah, looking at the archiving script, it gives an "INFO" message if optional
files are missing, but switches to that "WARNING" message if "required" files
are missing. Not sure why it doesn't actually fail, but it's apparently been
that way since at least 2010, so, oh, well.

[Lei Zhang, 2016-11-17 22:05:01]

On 2016/11/17 21:54:28, Michael Moss wrote:
> > Not sure. I only see warnings, which is how I a came up with the list to
> remove.
> > 
> > See the bottom and look for "WARNING:"
> 
> Yeah, looking at the archiving script, it gives an "INFO" message if optional
> files are missing, but switches to that "WARNING" message if "required" files
> are missing. Not sure why it doesn't actually fail, but it's apparently been
> that way since at least 2010, so, oh, well.

Well, this CL should fix those on Linux and ChromeOS. I haven't checked other
platforms. Not sure if you want to change that to a hard error, but that'll be
for another bug / CL / day.

[commit-bot: I haz the power, 2016-11-17 22:35:20]

Description was changed from

==========
Archive icudtl.dat in ChromeOS continuous builds.

Also remove obsolete file entires and sort the list a bit more.

BUG=666448
==========

to

==========
Archive icudtl.dat in ChromeOS continuous builds.

Also remove obsolete file entires and sort the list a bit more.

BUG=666448

Committed: https://crrev.com/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda
Cr-Commit-Position: refs/heads/master@{#432997}
==========

[commit-bot: I haz the power, 2016-11-17 22:35:21]

Patchset 1 (id:??) landed as
https://crrev.com/3dd2c2a6e2f6d21c084f72108b9e4db9a26e3dda
Cr-Commit-Position: refs/heads/master@{#432997}