Archive icudtl.dat in ChromeOS continuous builds.

chrome/tools/build/chromeos/FILES.cfg

 # -*- python -*-
 # ex: set syntax=python:
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is a buildbot configuration file containing a tagged list of files
 # processed by the stage/archive scripts. The known tags are:
 #
@@ skipping 23 matching lines @@
   },
   {
     'filename': 'chrome_100_percent.pak',
     'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'chrome_200_percent.pak',
     'buildtype': ['dev', 'official'],
   },
   {
-    'filename': 'chrome_sandbox',

[Lei Zhang, 2016/11/17 20:27:00]

Not built/used on ChromeOS.

[Michael Moss, 2016/11/17 20:49:29]

Why wasn't archiving failing due to "not found"? Is that check disabled on the
chromeos builders?

[Lei Zhang, 2016/11/17 21:37:10]

Not sure. I only see warnings, which is how I a came up with the list to remove.

See the bottom and look for "WARNING:"

https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/28742/steps...
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

-    'buildtype': ['dev', 'official'],
-  },
-  {
     'filename': 'chrome.1',
     'buildtype': ['dev', 'official'],
   },
   {
-    'filename': 'emit_login_prompt_ready',

[Lei Zhang, 2016/11/17 20:27:00]

I don't know what this is, but it doesn't exist.

-    'buildtype': ['dev'],
+    'filename': 'icudtl.dat',
+    'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'installer',
     'buildtype': ['official'],
   },
   {
+    'filename': 'locales',
+    'buildtype': ['dev', 'official'],
+  },
+  {
     'filename': 'natives_blob.bin',
     'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'snapshot_blob.bin',
     'buildtype': ['dev', 'official'],
   },
   {
-    'filename': 'locales',
-    'buildtype': ['dev', 'official'],
-  },
-  {
     'filename': 'product_logo_48.png',
     'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'resources',
     'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'resources.pak',
     'buildtype': ['dev', 'official'],
   },
   {
-    'filename': 'session',

[Lei Zhang, 2016/11/17 20:26:59]

Ditto.

-    'buildtype': ['dev'],
-  },
-  {
     'filename': 'xdg-mime',
     'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'xdg-settings',
     'buildtype': ['dev', 'official'],
   },
   # CDM files (each has an adapter and the actual CDM):
   {
     'filename': 'libclearkeycdmadapter.so',
@@ skipping 31 matching lines @@
   },
   {
     'filename': 'nacl_helper_bootstrap',
     'buildtype': ['dev', 'official'],
   },
   {
     'filename': 'nacl_helper_nonsfi',
     'buildtype': ['dev', 'official'],
   },
 ]