ash: Replace SessionStateDelegate::CanAddUserToMultiProfile

ash: Replace SessionStateDelegate::CanAddUserToMultiProfile

- Introduce a AddUserSessionPolicy for possible user adding scenarios;
- Replace CanAddUserToMultiProfile with GetAddUserSessionPolicy and
  update call sites;

This makes it easier for mojo interface replacement because it
only needs to cache a AddUserSessionPolicy enum then.

BUG=648964
Committed: https://crrev.com/24eba8859771c02f4df1f7aea4864e67bcdf7536
Cr-Commit-Position: refs/heads/master@{#433575}

[xiyuan, 2016-11-17 23:00:21]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[xiyuan, 2016-11-17 23:03:36]

xiyuan@chromium.org changed reviewers:
+ estade@chromium.org, jamescook@chromium.org, stevenjb@chromium.org

[xiyuan, 2016-11-17 23:03:37]

Suggested split:
jamescook@: everything
stevenjb@: chrome/browser/ui/ash/*
estade@: ash/common/system/user/user_view.cc

Thanks.

[commit-bot: I haz the power, 2016-11-17 23:03:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-17 23:18:14]

user_view.cc lgtm

https://codereview.chromium.org/2512693003/diff/1/ash/common/system/user/user...
File ash/common/system/user/user_view.cc (right):

https://codereview.chromium.org/2512693003/diff/1/ash/common/system/user/user...
ash/common/system/user/user_view.cc:121: int message_id =
IDS_ASH_STATUS_TRAY_SIGN_IN_ANOTHER_ACCOUNT;
nit: could you make this = 0 and assign this IDS to message_id in the
appropriate case below?

[stevenjb, 2016-11-17 23:21:58]

chrome/browser/ui/ash lgtm

[xiyuan, 2016-11-17 23:57:46]

https://codereview.chromium.org/2512693003/diff/1/ash/common/system/user/user...
File ash/common/system/user/user_view.cc (right):

https://codereview.chromium.org/2512693003/diff/1/ash/common/system/user/user...
ash/common/system/user/user_view.cc:121: int message_id =
IDS_ASH_STATUS_TRAY_SIGN_IN_ANOTHER_ACCOUNT;
On 2016/11/17 23:18:13, Evan Stade wrote:
> nit: could you make this = 0 and assign this IDS to message_id in the
> appropriate case below?

Done.

[xiyuan, 2016-11-17 23:57:51]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 00:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-11-18 00:24:08]

LGTM with optional nits. I like this much better.

https://codereview.chromium.org/2512693003/diff/20001/ash/common/session/sess...
File ash/common/session/session_types.h (right):

https://codereview.chromium.org/2512693003/diff/20001/ash/common/session/sess...
ash/common/session/session_types.h:21: ERROR_OUT_OF_USERS,
optional nit: What about ERROR_NO_ELIGIBLE_USERS? According to the UserManager
docs this not because of a limit on the number of users, but rather than no
current accounts are allowed to do it.

https://codereview.chromium.org/2512693003/diff/20001/ash/common/system/user/...
File ash/common/system/user/user_view.cc (right):

https://codereview.chromium.org/2512693003/diff/20001/ash/common/system/user/...
ash/common/system/user/user_view.cc:114: policy != AddUserSessionPolicy::ALLOWED
optional nit: reverse the conditional to policy == ALLOWED

[commit-bot: I haz the power, 2016-11-18 02:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:14:15]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-11-18 22:05:25]

https://codereview.chromium.org/2512693003/diff/20001/ash/common/session/sess...
File ash/common/session/session_types.h (right):

https://codereview.chromium.org/2512693003/diff/20001/ash/common/session/sess...
ash/common/session/session_types.h:21: ERROR_OUT_OF_USERS,
On 2016/11/18 00:24:08, James Cook wrote:
> optional nit: What about ERROR_NO_ELIGIBLE_USERS? According to the UserManager
> docs this not because of a limit on the number of users, but rather than no
> current accounts are allowed to do it.

Sounds good. Done.

https://codereview.chromium.org/2512693003/diff/20001/ash/common/system/user/...
File ash/common/system/user/user_view.cc (right):

https://codereview.chromium.org/2512693003/diff/20001/ash/common/system/user/...
ash/common/system/user/user_view.cc:114: policy != AddUserSessionPolicy::ALLOWED
On 2016/11/18 00:24:08, James Cook wrote:
> optional nit: reverse the conditional to policy == ALLOWED

Done.

[xiyuan, 2016-11-18 22:05:30]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-11-18 22:05:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, estade@chromium.org, jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2512693003/#ps40001
(title: "for #2")

[commit-bot: I haz the power, 2016-11-18 22:06:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 02:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 02:25:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-11-21 16:37:46]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-11-21 16:38:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 17:18:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479746266403210,
"parent_rev": "323555a8fd4af9edb7e706087f7499095fe2a65f", "commit_rev":
"988a12bd009723c8e8f5770e19d665d9172a1185"}

[commit-bot: I haz the power, 2016-11-21 17:19:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-21 17:21:20]

Description was changed from

==========
ash: Replace SessionStateDelegate::CanAddUserToMultiProfile

- Introduce a AddUserSessionPolicy for possible user adding scenarios;
- Replace CanAddUserToMultiProfile with GetAddUserSessionPolicy and
  update call sites;

This makes it easier for mojo interface replacement because it
only needs to cache a AddUserSessionPolicy enum then.

BUG=648964
==========

to

==========
ash: Replace SessionStateDelegate::CanAddUserToMultiProfile

- Introduce a AddUserSessionPolicy for possible user adding scenarios;
- Replace CanAddUserToMultiProfile with GetAddUserSessionPolicy and
  update call sites;

This makes it easier for mojo interface replacement because it
only needs to cache a AddUserSessionPolicy enum then.

BUG=648964

Committed: https://crrev.com/24eba8859771c02f4df1f7aea4864e67bcdf7536
Cr-Commit-Position: refs/heads/master@{#433575}
==========

[commit-bot: I haz the power, 2016-11-21 17:21:21]

Patchset 3 (id:??) landed as
https://crrev.com/24eba8859771c02f4df1f7aea4864e67bcdf7536
Cr-Commit-Position: refs/heads/master@{#433575}