ash: Replace SessionStateDelegate::CanAddUserToMultiProfile

ash/common/system/user/user_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/user/user_view.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "ash/common/material_design/material_design_controller.h"
@@ skipping 11 matching lines @@
 #include "ash/common/system/user/button_from_view.h"
 #include "ash/common/system/user/login_status.h"
 #include "ash/common/system/user/rounded_image_view.h"
 #include "ash/common/system/user/user_card_view.h"
 #include "ash/common/wm_lookup.h"
 #include "ash/common/wm_root_window_controller.h"
 #include "ash/common/wm_shell.h"
 #include "ash/common/wm_window.h"
 #include "ash/public/cpp/shell_window_ids.h"
 #include "ash/resources/vector_icons/vector_icons.h"
-#include "base/optional.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "components/user_manager/user_info.h"
 #include "grit/ash_resources.h"
 #include "grit/ash_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/insets.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/views/controls/button/label_button.h"
@@ skipping 55 matching lines @@
       MultiProfileUMA::SWITCH_ACTIVE_USER_BY_TRAY);
   delegate->SwitchActiveUser(delegate->GetUserInfo(user_index)->GetAccountId());
 }
 
 bool IsMultiProfileSupportedAndUserActive() {
   return WmShell::Get()->delegate()->IsMultiProfilesEnabled() &&
          !WmShell::Get()->GetSessionStateDelegate()->IsUserSessionBlocked();
 }
 
 // Creates the view shown in the user switcher popup ("AddUserMenuOption").
-views::View* CreateAddUserView(
-    base::Optional<SessionStateDelegate::AddUserError> error) {
+views::View* CreateAddUserView(AddUserSessionPolicy policy) {
   DCHECK(UseMd());
   auto view = new views::View;
   auto layout = new views::BoxLayout(
       views::BoxLayout::kHorizontal, (kMenuButtonSize - kMenuIconSize) / 2,
       kMenuSeparatorVerticalPadding, kTrayPopupPaddingBetweenItems);
   layout->set_minimum_cross_axis_size(
-      error ? 56 : GetTrayConstant(TRAY_POPUP_ITEM_MIN_HEIGHT));
+      policy != AddUserSessionPolicy::ALLOWED
+          ? 56
+          : GetTrayConstant(TRAY_POPUP_ITEM_MIN_HEIGHT));
   view->SetLayoutManager(layout);
   view->set_background(
       views::Background::CreateSolidBackground(kBackgroundColor));
 
-  if (!error) {
-    auto icon = new views::ImageView();
-    icon->SetImage(
-        gfx::CreateVectorIcon(kSystemMenuNewUserIcon, kMenuIconColor));
-    view->AddChildView(icon);
-  }
-
   int message_id = IDS_ASH_STATUS_TRAY_SIGN_IN_ANOTHER_ACCOUNT;

[Evan Stade, 2016/11/17 23:18:13]

nit: could you make this = 0 and assign this IDS to message_id in the
appropriate case below?

[xiyuan, 2016/11/17 23:57:46]

Done.

-  if (error) {
-    switch (*error) {
-      case SessionStateDelegate::ADD_USER_ERROR_NOT_ALLOWED_PRIMARY_USER:
-        message_id = IDS_ASH_STATUS_TRAY_MESSAGE_NOT_ALLOWED_PRIMARY_USER;
-        break;
-      case SessionStateDelegate::ADD_USER_ERROR_MAXIMUM_USERS_REACHED:
-        message_id = IDS_ASH_STATUS_TRAY_MESSAGE_CANNOT_ADD_USER;
-        break;
-      case SessionStateDelegate::ADD_USER_ERROR_OUT_OF_USERS:
-        message_id = IDS_ASH_STATUS_TRAY_MESSAGE_OUT_OF_USERS;
-        break;
+  switch (policy) {
+    case AddUserSessionPolicy::ALLOWED: {
+      auto icon = new views::ImageView();
+      icon->SetImage(
+          gfx::CreateVectorIcon(kSystemMenuNewUserIcon, kMenuIconColor));
+      view->AddChildView(icon);
+      break;
     }
+    case AddUserSessionPolicy::ERROR_NOT_ALLOWED_PRIMARY_USER:
+      message_id = IDS_ASH_STATUS_TRAY_MESSAGE_NOT_ALLOWED_PRIMARY_USER;
+      break;
+    case AddUserSessionPolicy::ERROR_MAXIMUM_USERS_REACHED:
+      message_id = IDS_ASH_STATUS_TRAY_MESSAGE_CANNOT_ADD_USER;
+      break;
+    case AddUserSessionPolicy::ERROR_OUT_OF_USERS:
+      message_id = IDS_ASH_STATUS_TRAY_MESSAGE_OUT_OF_USERS;
+      break;
   }
 
   auto command_label = new views::Label(l10n_util::GetStringUTF16(message_id));
   command_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   command_label->SetMultiLine(true);
   view->AddChildView(command_label);
   return view;
 }
 
 class UserViewMouseWatcherHost : public views::MouseWatcherHost {
@@ skipping 446 matching lines @@
   WmLookup::Get()
       ->GetWindowForWidget(GetWidget())
       ->GetRootWindowController()
       ->ConfigureWidgetInitParamsForContainer(
           add_menu_option_.get(), kShellWindowId_DragImageAndTooltipContainer,
           &params);
   add_menu_option_->Init(params);
 
   const SessionStateDelegate* delegate =
       WmShell::Get()->GetSessionStateDelegate();
-  SessionStateDelegate::AddUserError add_user_error;
-  add_user_enabled_ = delegate->CanAddUserToMultiProfile(&add_user_error);
+  const AddUserSessionPolicy add_user_policy =
+      delegate->GetAddUserSessionPolicy();
+  add_user_enabled_ = add_user_policy == AddUserSessionPolicy::ALLOWED;
 
   if (UseMd()) {
-    base::Optional<SessionStateDelegate::AddUserError> error;
-    if (!add_user_enabled_)
-      error = add_user_error;
     ButtonFromView* button = new ButtonFromView(
-        CreateAddUserView(error), add_user_enabled_ ? this : nullptr,
+        CreateAddUserView(add_user_policy), add_user_enabled_ ? this : nullptr,
         IsActiveUser() ? TrayPopupInkDropStyle::INSET_BOUNDS
                        : TrayPopupInkDropStyle::FILL_BOUNDS,
         false, gfx::Insets());
     button->SetAccessibleName(
         l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_SIGN_IN_ANOTHER_ACCOUNT));
     button->ForceBorderVisible(true);
 
     // Position the widget on top of the user card view (which is still in the
     // system menu). The top half of the widget will be transparent to allow
     // the active user to show through.
@@ skipping 47 matching lines @@
 
     if (add_user_enabled_) {
       // We activate the entry automatically if invoked with focus.
       if (user_card_view_->HasFocus()) {
         button->GetFocusManager()->SetFocusedView(button);
         user_card_view_->GetFocusManager()->SetFocusedView(button);
       }
     } else {
       ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
       int message_id = 0;
-      switch (add_user_error) {
-        case SessionStateDelegate::ADD_USER_ERROR_NOT_ALLOWED_PRIMARY_USER:
+      switch (add_user_policy) {
+        case AddUserSessionPolicy::ERROR_NOT_ALLOWED_PRIMARY_USER:
           message_id = IDS_ASH_STATUS_TRAY_MESSAGE_NOT_ALLOWED_PRIMARY_USER;
           break;
-        case SessionStateDelegate::ADD_USER_ERROR_MAXIMUM_USERS_REACHED:
+        case AddUserSessionPolicy::ERROR_MAXIMUM_USERS_REACHED:
           message_id = IDS_ASH_STATUS_TRAY_MESSAGE_CANNOT_ADD_USER;
           break;
-        case SessionStateDelegate::ADD_USER_ERROR_OUT_OF_USERS:
+        case AddUserSessionPolicy::ERROR_OUT_OF_USERS:
           message_id = IDS_ASH_STATUS_TRAY_MESSAGE_OUT_OF_USERS;
           break;
         default:
-          NOTREACHED() << "Unknown adding user error " << add_user_error;
+          NOTREACHED() << "Unknown adding user policy "
+                       << static_cast<int>(add_user_policy);
       }
 
       popup_message_.reset(new PopupMessage(
           bundle.GetLocalizedString(
               IDS_ASH_STATUS_TRAY_CAPTION_CANNOT_ADD_USER),
           bundle.GetLocalizedString(message_id), PopupMessage::ICON_WARNING,
           add_user_view->anchor(), views::BubbleBorder::TOP_LEFT,
           gfx::Size(parent()->bounds().width() - kPopupMessageOffset, 0),
           2 * kPopupMessageOffset));
     }
@@ skipping 19 matching lines @@
   focus_manager_ = nullptr;
   if (user_card_view_->GetFocusManager())
     user_card_view_->GetFocusManager()->ClearFocus();
   popup_message_.reset();
   mouse_watcher_.reset();
   add_menu_option_.reset();
 }
 
 }  // namespace tray
 }  // namespace ash