Merge of source position information from kernel-sdk.

Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/6fd3a42edb4c7902a49811318de6bb6b18dbd829
Committed: https://github.com/dart-lang/sdk/commit/63e9c7641bf9864eeb85b1675abed2c5e84f72ca

[jensj, 2016-11-17 12:37:12]

Description was changed from

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.
==========

to

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/
==========

[jensj, 2016-11-17 12:37:12]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2016-11-21 08:06:18]

LGTM.

https://codereview.chromium.org/2512653002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2512653002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:8849: if (this->kind() == RawScript::kKernelTag) {
Don't need this->

[jensj, 2016-11-21 09:18:43]

Will land then.
As a small note though, this will also undo (or supersede or whatnot)
https://github.com/dart-lang/sdk/commit/30e01bcd675c8be01237fe66f65f5c3c5c0b62a6
/ https://codereview.chromium.org/2511883002.

https://codereview.chromium.org/2512653002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2512653002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:8849: if (this->kind() == RawScript::kKernelTag) {
On 2016/11/21 08:06:18, Kevin Millikin (Google) wrote:
> Don't need this->

Done.

[jensj, 2016-11-21 09:19:37]

Description was changed from

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/
==========

to

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6fd3a42edb4c7902a49811318de6bb6b18dbd829
==========

[jensj, 2016-11-21 09:19:38]

Committed patchset #1 (id:1) manually as
6fd3a42edb4c7902a49811318de6bb6b18dbd829 (presubmit successful).

[jensj, 2016-11-21 10:28:26]

Description was changed from

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6fd3a42edb4c7902a49811318de6bb6b18dbd829
==========

to

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6fd3a42edb4c7902a49811318de6bb6b18dbd829
==========

[jensj, 2016-11-21 12:33:12]

Patchset #2 (id:20001) has been deleted

[jensj, 2016-11-21 12:46:00]

PTAL.

Fixed 2 failing unit tests (vm/cc/IsolateReload_TypeIdentityGeneric and
vm/cc/SourceReport_Coverage_AllFunctions_ForceCompile) caused by "column" being
uninitialized because of the rewrite done on Script::GetTokenLocation. This in
turn caused Script::GetSnippet to return a null-string and the tests died.

I went back to the original "if (column == NULL)" check in
Script::GetTokenLocation and calling it "the original way" (i.e. as either
"script.GetTokenLocation(token_pos, &line, &column)" or
"script.GetTokenLocation(token_pos, &line, NULL)").

Changes in object.cc and exceptions.cc.

[Kevin Millikin (Google), 2016-11-21 13:11:34]

LGTM.

[jensj, 2016-11-21 13:13:53]

Description was changed from

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6fd3a42edb4c7902a49811318de6bb6b18dbd829
==========

to

==========
Merge of source position information from kernel-sdk.

I.e. use offsets (on some nodes) in the dill file to
get stacktraces with line- and column numbers.

"sdk" version of "kernel-sdk"s
https://chromereviews.googleplex.com/520617013/

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6fd3a42edb4c7902a49811318de6bb6b18dbd829
Committed:
https://github.com/dart-lang/sdk/commit/63e9c7641bf9864eeb85b1675abed2c5e84f72ca
==========

[jensj, 2016-11-21 13:13:56]

Committed patchset #2 (id:40001) manually as
63e9c7641bf9864eeb85b1675abed2c5e84f72ca (presubmit successful).