VM: [Kernel] Relax assertion in Script::GetTokenLocation().

VM: [Kernel] Relax assertion in Script::GetTokenLocation().

Kernel binaries do not carry token streams.

Introduce a dummy URI to identify dummy Script objects created for Kernel entities.

R=rmacnak@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/30e01bcd675c8be01237fe66f65f5c3c5c0b62a6

[rmacnak, 2016-11-17 20:13:31]

lgtm

https://codereview.chromium.org/2511883002/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2511883002/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:166: H.DartString(""), RawScript::kScriptTag));
There's a Symbols::Empty() btw.

[kustermann, 2016-11-18 09:45:50]

kustermann@google.com changed reviewers:
+ kustermann@google.com

[kustermann, 2016-11-18 09:45:51]

https://codereview.chromium.org/2511883002/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2511883002/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:163: // TODO(27590): Figure out why we need this
script stuff here.
We need a valid [Script] for example because the [Script] object contains e.g.
cached constants

Maybe remove this comment?

[Vyacheslav Egorov (Google), 2016-11-18 14:49:46]

Thanks

https://codereview.chromium.org/2511883002/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2511883002/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:163: // TODO(27590): Figure out why we need this
script stuff here.
On 2016/11/18 09:45:51, kustermann wrote:
> We need a valid [Script] for example because the [Script] object contains e.g.
> cached constants
> 
> Maybe remove this comment?

Done.

https://codereview.chromium.org/2511883002/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:166: H.DartString(""), RawScript::kScriptTag));
On 2016/11/17 20:13:31, rmacnak wrote:
> There's a Symbols::Empty() btw.

Done.

[Vyacheslav Egorov (Google), 2016-11-18 14:58:18]

Description was changed from

==========
VM: [Kernel] Relax assertion in Script::GetTokenLocation().

Kernel binaries do not carry token streams.

Introduce a dummy URI to identify dummy Script objects created for Kernel
entities.

R=rmacnak@google.com
BUG=
==========

to

==========
VM: [Kernel] Relax assertion in Script::GetTokenLocation().

Kernel binaries do not carry token streams.

Introduce a dummy URI to identify dummy Script objects created for Kernel
entities.

R=rmacnak@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/30e01bcd675c8be01237fe66f65f5c3c5c0b62a6
==========

[Vyacheslav Egorov (Google), 2016-11-18 14:58:20]

Committed patchset #1 (id:1) manually as
30e01bcd675c8be01237fe66f65f5c3c5c0b62a6 (presubmit successful).