Chromium Code Reviews Chromium Code Reviews
Issue 2512613003:
remove unnecessary paper-item dependency from site_details. (Closed)
| Index: chrome/browser/resources/settings/site_settings/site_details.html |
| diff --git a/chrome/browser/resources/settings/site_settings/site_details.html b/chrome/browser/resources/settings/site_settings/site_details.html |
| index 9a93225392e5e34e3d04b6f15b6fa215a5e98f74..75eeef1a186aad073081593f678a1273705c7faa 100644 |
| --- a/chrome/browser/resources/settings/site_settings/site_details.html |
| +++ b/chrome/browser/resources/settings/site_settings/site_details.html |
| @@ -3,6 +3,7 @@ |
| <link rel="import" href="chrome://resources/cr_elements/icons.html"> |
| <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout.html"> |
| <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html"> |
| +<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html"> |
|
dpapad
2016/11/17 23:59:28
Let's remove this dependency.
scottchen
2016/11/18 02:09:43
Done.
|
| <link rel="import" href="/route.html"> |
| <link rel="import" href="/settings_shared_css.html"> |
| <link rel="import" href="/site_settings/constants.html"> |
| @@ -46,12 +47,12 @@ |
| <h2>$i18n{siteSettingsUsage}</h2> |
| </div> |
| <div class="list-frame"> |
| - <paper-item id="storage" hidden$="[[!storedData_]]"> |
| + <div class="list-item" id="storage"> |
|
dpapad
2016/11/17 23:36:58
We still need the hidden$="[[!storedData_]] part,
scottchen
2016/11/17 23:55:50
An ancestor element has the exact same hidden cond
dpapad
2016/11/17 23:59:28
I see. Good catch.
scottchen
2016/11/18 02:09:43
Done.
|
| <div class="flex">[[storedData_]]</div> |
| <paper-icon-button icon="cr:delete" |
| on-tap="onConfirmClearStorage_" |
| alt="$i18n{siteSettingsDelete}"></paper-icon-button> |
| - </paper-item> |
| + </div> |
| </div> |
| </div> |
| <div class="settings-box first"> |
