Convert enable_plugins to a buildflag header.

Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header //ppapi/features:features. Updates callers to use BUILDFLAG, include the new header, and depend on this target.

R=bbudge
TBR=rsesek@chromium.org (*_messages.h files).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4b46108b37f0e0c7de0f86f3dc1d229e1a2bf168
Cr-Commit-Position: refs/heads/master@{#433426}

[brettw, 2016-11-17 16:23:19]

Description was changed from

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.
==========

to

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[brettw, 2016-11-17 16:55:20]

Self review

[brettw, 2016-11-17 16:55:20]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 17:41:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 17:41:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-11-17 19:16:31]

brettw@chromium.org changed reviewers:
+ bbudge@chromium.org

[brettw, 2016-11-17 19:17:02]

Missing Mac dep

[brettw, 2016-11-17 19:17:03]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 19:17:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 19:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:31:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-11-17 20:02:13]

Mac for realz

[brettw, 2016-11-17 20:02:14]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[bbudge, 2016-11-17 20:03:07]

pepper / ppapi lgtm

[commit-bot: I haz the power, 2016-11-17 20:04:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-11-17 20:25:29]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-11-17 20:25:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:26:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-11-17 21:17:35]

Description was changed from

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.

R=bbudge
TBR=rsesek@chromium.org (*_messages.h files).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[brettw, 2016-11-17 21:18:07]

brettw@chromium.org changed reviewers:
+ rsesek@chromium.org

[brettw, 2016-11-17 21:18:08]

+rsesek TBR for mechanical changes in *_messages.h files.

[Robert Sesek, 2016-11-17 21:23:13]

lgtm

[commit-bot: I haz the power, 2016-11-17 22:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:09:59]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-11-17 22:17:08]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:18:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:22:11]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-11-18 18:25:00]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-18 18:26:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:30:09]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-11-19 15:08:14]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-19 15:08:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 15:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 15:52:30]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-19 16:27:26]

Merge

[brettw, 2016-11-19 16:27:27]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-19 16:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/2512563003/#ps80001
(title: "Merge")

[commit-bot: I haz the power, 2016-11-19 16:27:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 18:55:41]

Description was changed from

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.

R=bbudge
TBR=rsesek@chromium.org (*_messages.h files).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.

R=bbudge
TBR=rsesek@chromium.org (*_messages.h files).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-11-19 18:55:43]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-19 18:58:18]

Description was changed from

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.

R=bbudge
TBR=rsesek@chromium.org (*_messages.h files).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert enable_plugins to a buildflag header.

Moves the build flag from build/config/features.gni to
ppapi/features/features.gni so it's not global any more.

Moves the define from build/config (global) to a generated buildflag header
//ppapi/features:features. Updates callers to use BUILDFLAG, include the new
header, and depend on this target.

R=bbudge
TBR=rsesek@chromium.org (*_messages.h files).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4b46108b37f0e0c7de0f86f3dc1d229e1a2bf168
Cr-Commit-Position: refs/heads/master@{#433426}
==========

[commit-bot: I haz the power, 2016-11-19 18:58:21]

Patchset 5 (id:??) landed as
https://crrev.com/4b46108b37f0e0c7de0f86f3dc1d229e1a2bf168
Cr-Commit-Position: refs/heads/master@{#433426}