Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: build/config/BUILD.gn

Issue 2512563003: Convert enable_plugins to a buildflag header. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/features.gni") 10 import("//build/config/features.gni")
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 # This will also allow you to scope your build flag to a BUILD.gn file (or a 58 # This will also allow you to scope your build flag to a BUILD.gn file (or a
59 # .gni file if you need it from more than one place) rather than making global 59 # .gni file if you need it from more than one place) rather than making global
60 # flags. See //build/config/BUILDCONFIG.gn for advice on where to define 60 # flags. See //build/config/BUILDCONFIG.gn for advice on where to define
61 # build flags. 61 # build flags.
62 config("feature_flags") { 62 config("feature_flags") {
63 # Don't use deprecated V8 APIs anywhere. 63 # Don't use deprecated V8 APIs anywhere.
64 defines = [ "V8_DEPRECATION_WARNINGS" ] 64 defines = [ "V8_DEPRECATION_WARNINGS" ]
65 if (enable_notifications) { 65 if (enable_notifications) {
66 defines += [ "ENABLE_NOTIFICATIONS" ] 66 defines += [ "ENABLE_NOTIFICATIONS" ]
67 } 67 }
68 if (enable_plugins) {
69 defines += [ "ENABLE_PLUGINS=1" ]
70 }
71 if (enable_pdf) { 68 if (enable_pdf) {
72 defines += [ "ENABLE_PDF=1" ] 69 defines += [ "ENABLE_PDF=1" ]
73 } 70 }
74 if (dcheck_always_on) { 71 if (dcheck_always_on) {
75 defines += [ "DCHECK_ALWAYS_ON=1" ] 72 defines += [ "DCHECK_ALWAYS_ON=1" ]
76 } 73 }
77 if (use_udev) { 74 if (use_udev) {
78 # TODO(brettw) should probably be "=1". 75 # TODO(brettw) should probably be "=1".
79 defines += [ "USE_UDEV" ] 76 defines += [ "USE_UDEV" ]
80 } 77 }
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 # file doesn't exist, no error will be generated (probably MS tested this 415 # file doesn't exist, no error will be generated (probably MS tested this
419 # case but forgot the other one?). To reproduce this error, do a build, 416 # case but forgot the other one?). To reproduce this error, do a build,
420 # then delete the precompile.c.obj file, then build again. 417 # then delete the precompile.c.obj file, then build again.
421 cflags_c = [ "/wd4206" ] 418 cflags_c = [ "/wd4206" ]
422 } else if (is_mac) { 419 } else if (is_mac) {
423 precompiled_header = "build/precompile.h" 420 precompiled_header = "build/precompile.h"
424 precompiled_source = "//build/precompile.h" 421 precompiled_source = "//build/precompile.h"
425 } 422 }
426 } 423 }
427 } 424 }
OLDNEW
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698