Add GetIsPinnedToTaskbarState()

chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
index 3800b973a166f222d7a8bf01ca346333cd0741f0..ad3d51ccd3bc974a8497d3a4f0342401720650b6 100644
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
@@ -113,8 +113,8 @@ enum UMATouchEventsState {
 
 #if defined(OS_ANDROID) && defined(__arm__)
 enum UMAAndroidArmFpu {
-  UMA_ANDROID_ARM_FPU_VFPV3_D16, // The ARM CPU only supports vfpv3-d16.
-  UMA_ANDROID_ARM_FPU_NEON,      // The Arm CPU supports NEON.
+  UMA_ANDROID_ARM_FPU_VFPV3_D16,  // The ARM CPU only supports vfpv3-d16.
+  UMA_ANDROID_ARM_FPU_NEON,       // The Arm CPU supports NEON.
   UMA_ANDROID_ARM_FPU_COUNT
 };
 #endif  // defined(OS_ANDROID) && defined(__arm__)
@@ -314,6 +314,35 @@ void AsynchronousTouchEventStateRecorder::OnDeviceListsComplete() {
 
 #endif  // defined(USE_OZONE) || defined(USE_X11)
 
+#if defined(OS_WIN)
+void RecordPinnedToTaskbarProcessError(bool error) {
+  UMA_HISTOGRAM_BOOLEAN("Windows.IsPinnedToTaskbar.ProcessError", error);
+}
+
+void OnShellHandlerConnectionError() {
+  RecordPinnedToTaskbarProcessError(true);
+}
+
+// Record the UMA histogram when a response is received.
+void OnIsPinnedToTaskbarResult(bool succeeded, bool is_pinned_to_taskbar) {
+  RecordPinnedToTaskbarProcessError(false);
+
+  enum Result { NOT_PINNED, PINNED, FAILURE, NUM_RESULTS };

[grt (UTC plus 2), 2016/11/22 10:06:41]

nit: since this must be in sync with histograms.xml and the items must not have
their values modified, i think it's nice to give them explicit values here and
add a comment saying not to reorder:
  // Used for histograms; do not reorder.
  enum Result {
    NOT_PINNED = 0,
    PINNED = 1,
    FAILURE = 2,
    NUM_RESULTS
  };

[Patrick Monette, 2016/11/22 22:41:59]

Done.

+
+  Result result = FAILURE;
+  if (succeeded)
+    result = is_pinned_to_taskbar ? PINNED : NOT_PINNED;
+  UMA_HISTOGRAM_ENUMERATION("Windows.IsPinnedToTaskbar", result, NUM_RESULTS);
+}
+
+// Records the pinned state of the current executable into a histogram.
+void RecordIsPinnedToTaskbarHistogram() {
+  shell_integration::win::GetIsPinnedToTaskbarState(
+      base::Bind(&OnShellHandlerConnectionError),
+      base::Bind(&OnIsPinnedToTaskbarResult));
+}
+#endif  // defined(OS_WIN)
+
 }  // namespace
 
 ChromeBrowserMainExtraPartsMetrics::ChromeBrowserMainExtraPartsMetrics()
@@ -369,7 +398,7 @@ void ChromeBrowserMainExtraPartsMetrics::PostBrowserStart() {
 #if defined(OS_WIN)
   content::BrowserThread::PostDelayedTask(
       content::BrowserThread::IO, FROM_HERE,
-      base::Bind(&shell_integration::win::RecordIsPinnedToTaskbarHistogram),
+      base::Bind(&RecordIsPinnedToTaskbarHistogram),
       kStartupMetricsGatheringDelay);
 #endif  // defined(OS_WIN)