Add GetIsPinnedToTaskbarState()

chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 95 matching lines @@
   UMA_TOUCH_EVENTS_AUTO_DISABLED,
   UMA_TOUCH_EVENTS_DISABLED,
   // NOTE: Add states only immediately above this line. Make sure to
   // update the enum list in tools/metrics/histograms/histograms.xml
   // accordingly.
   UMA_TOUCH_EVENTS_STATE_COUNT
 };
 
 #if defined(OS_ANDROID) && defined(__arm__)
 enum UMAAndroidArmFpu {
-  UMA_ANDROID_ARM_FPU_VFPV3_D16, // The ARM CPU only supports vfpv3-d16.
-  UMA_ANDROID_ARM_FPU_NEON,      // The Arm CPU supports NEON.
+  UMA_ANDROID_ARM_FPU_VFPV3_D16,  // The ARM CPU only supports vfpv3-d16.
+  UMA_ANDROID_ARM_FPU_NEON,       // The Arm CPU supports NEON.
   UMA_ANDROID_ARM_FPU_COUNT
 };
 #endif  // defined(OS_ANDROID) && defined(__arm__)
 
 void RecordMicroArchitectureStats() {
 #if defined(ARCH_CPU_X86_FAMILY)
   base::CPU cpu;
   base::CPU::IntelMicroArchitecture arch = cpu.GetIntelMicroArchitecture();
   UMA_HISTOGRAM_ENUMERATION("Platform.IntelMaxMicroArchitecture", arch,
                             base::CPU::MAX_INTEL_MICRO_ARCHITECTURE);
@@ skipping 179 matching lines @@
   ui::InputDeviceManager::GetInstance()->RemoveObserver(this);
 }
 
 void AsynchronousTouchEventStateRecorder::OnDeviceListsComplete() {
   ui::InputDeviceManager::GetInstance()->RemoveObserver(this);
   RecordTouchEventState();
 }
 
 #endif  // defined(USE_OZONE) || defined(USE_X11)
 
+#if defined(OS_WIN)
+void RecordPinnedToTaskbarProcessError(bool error) {
+  UMA_HISTOGRAM_BOOLEAN("Windows.IsPinnedToTaskbar.ProcessError", error);
+}
+
+void OnShellHandlerConnectionError() {
+  RecordPinnedToTaskbarProcessError(true);
+}
+
+// Record the UMA histogram when a response is received.
+void OnIsPinnedToTaskbarResult(bool succeeded, bool is_pinned_to_taskbar) {
+  RecordPinnedToTaskbarProcessError(false);
+
+  enum Result { NOT_PINNED, PINNED, FAILURE, NUM_RESULTS };

[grt (UTC plus 2), 2016/11/22 10:06:41]

nit: since this must be in sync with histograms.xml and the items must not have
their values modified, i think it's nice to give them explicit values here and
add a comment saying not to reorder:
  // Used for histograms; do not reorder.
  enum Result {
    NOT_PINNED = 0,
    PINNED = 1,
    FAILURE = 2,
    NUM_RESULTS
  };

[Patrick Monette, 2016/11/22 22:41:59]

Done.

+
+  Result result = FAILURE;
+  if (succeeded)
+    result = is_pinned_to_taskbar ? PINNED : NOT_PINNED;
+  UMA_HISTOGRAM_ENUMERATION("Windows.IsPinnedToTaskbar", result, NUM_RESULTS);
+}
+
+// Records the pinned state of the current executable into a histogram.
+void RecordIsPinnedToTaskbarHistogram() {
+  shell_integration::win::GetIsPinnedToTaskbarState(
+      base::Bind(&OnShellHandlerConnectionError),
+      base::Bind(&OnIsPinnedToTaskbarResult));
+}
+#endif  // defined(OS_WIN)
+
 }  // namespace
 
 ChromeBrowserMainExtraPartsMetrics::ChromeBrowserMainExtraPartsMetrics()
     : display_count_(0), is_screen_observer_(false) {
 }
 
 ChromeBrowserMainExtraPartsMetrics::~ChromeBrowserMainExtraPartsMetrics() {
   if (is_screen_observer_)
     display::Screen::GetScreen()->RemoveObserver(this);
 }
@@ skipping 35 matching lines @@
 #endif  // defined(OS_MACOSX)
 
   constexpr base::TimeDelta kStartupMetricsGatheringDelay =
       base::TimeDelta::FromSeconds(45);
   content::BrowserThread::GetBlockingPool()->PostDelayedTask(
       FROM_HERE, base::Bind(&RecordStartupMetricsOnBlockingPool),
       kStartupMetricsGatheringDelay);
 #if defined(OS_WIN)
   content::BrowserThread::PostDelayedTask(
       content::BrowserThread::IO, FROM_HERE,
-      base::Bind(&shell_integration::win::RecordIsPinnedToTaskbarHistogram),
+      base::Bind(&RecordIsPinnedToTaskbarHistogram),
       kStartupMetricsGatheringDelay);
 #endif  // defined(OS_WIN)
 
   display_count_ = display::Screen::GetScreen()->GetNumDisplays();
   UMA_HISTOGRAM_COUNTS_100("Hardware.Display.Count.OnStartup", display_count_);
   display::Screen::GetScreen()->AddObserver(this);
   is_screen_observer_ = true;
 
 #if !defined(OS_ANDROID)
   FirstWebContentsProfiler::Start();
@@ skipping 23 matching lines @@
   }
 }
 
 namespace chrome {
 
 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts) {
   main_parts->AddParts(new ChromeBrowserMainExtraPartsMetrics());
 }
 
 }  // namespace chrome