Avoid special handling of LayoutSVGForeignObject about its paint offset

Avoid special handling of LayoutSVGForeignObject about its paint offset

Previously we painted a LayoutSVGForeignObject in the following way:
1 Issue transform and clip based on localSVGTransform;
2 Call BlockFlowPainter::paint with zero LayoutPoint()
3 BlockFlowPainter::paint uses the object's location() as the actual
  paint offset.

The above painting method also required us to generate the same paint
properties in PaintPropertyTreeBuilder.

This CL change painting of LayoutSVGForiegnObject in a new way:
1 Issue transform and clip based on localToSVGParentTransform which
  includes the viewport offset;
2 Call BlockFlowPainter::paint with -location() as the paint offset;
3 BlockFlowPainter::paint then add the object's location() to the
  paint offset which results a zero paint offset.

With the new method, LayoutSVGForeignObject behaves more like a normal
SVG object so we can remove some special handling of it.

BUG=666416
x
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
Cr-Commit-Position: refs/heads/master@{#433080}

[Xianzhu, 2016-11-17 19:22:11]

Description was changed from

==========
Avoid special handling of LayoutSVGForeignObject about its paint offset

Previously we painted a LayoutSVGForeignObject in the following way:
1 Issue transform and clip based on localSVGTransform;
2 Call BlockFlowPainter::paint with zero LayoutPoint()
3 BlockFlowPainter::paint uses the object's location() as the actual
  paint offset.

The above painting method also required us to generate the same paint
properties in PaintPropertyTreeBuilder.

This CL change painting of LayoutSVGForiegnObject in a new way:
1 Issue transform and clip based on localToSVGParentTransform which
  includes the viewport offset;
2 Call BlockFlowPainter::paint with -location() as the paint offset;
3 BlockFlowPainter::paint then add the object's location() to the
  paint offset which results a zero paint offset.

With the new method, LayoutSVGForeignObject behaves more like a normal
SVG object so we can remove some special handling of it.

BUG=666416

x
==========

to

==========
Avoid special handling of LayoutSVGForeignObject about its paint offset

Previously we painted a LayoutSVGForeignObject in the following way:
1 Issue transform and clip based on localSVGTransform;
2 Call BlockFlowPainter::paint with zero LayoutPoint()
3 BlockFlowPainter::paint uses the object's location() as the actual
  paint offset.

The above painting method also required us to generate the same paint
properties in PaintPropertyTreeBuilder.

This CL change painting of LayoutSVGForiegnObject in a new way:
1 Issue transform and clip based on localToSVGParentTransform which
  includes the viewport offset;
2 Call BlockFlowPainter::paint with -location() as the paint offset;
3 BlockFlowPainter::paint then add the object's location() to the
  paint offset which results a zero paint offset.

With the new method, LayoutSVGForeignObject behaves more like a normal
SVG object so we can remove some special handling of it.

BUG=666416

x
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-11-17 19:22:23]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 19:23:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-17 19:47:16]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 19:47:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-17 19:48:16]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:47:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:47:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-11-17 21:56:50]

On 2016/11/17 at 19:48:17, wangxianzhu wrote:
> 

Nice cleanup!
LGTM

[Xianzhu, 2016-11-17 22:00:43]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:03:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:06:43]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-11-18 00:16:09]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:18:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 03:54:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 03:56:57]

Description was changed from

==========
Avoid special handling of LayoutSVGForeignObject about its paint offset

Previously we painted a LayoutSVGForeignObject in the following way:
1 Issue transform and clip based on localSVGTransform;
2 Call BlockFlowPainter::paint with zero LayoutPoint()
3 BlockFlowPainter::paint uses the object's location() as the actual
  paint offset.

The above painting method also required us to generate the same paint
properties in PaintPropertyTreeBuilder.

This CL change painting of LayoutSVGForiegnObject in a new way:
1 Issue transform and clip based on localToSVGParentTransform which
  includes the viewport offset;
2 Call BlockFlowPainter::paint with -location() as the paint offset;
3 BlockFlowPainter::paint then add the object's location() to the
  paint offset which results a zero paint offset.

With the new method, LayoutSVGForeignObject behaves more like a normal
SVG object so we can remove some special handling of it.

BUG=666416

x
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Avoid special handling of LayoutSVGForeignObject about its paint offset

Previously we painted a LayoutSVGForeignObject in the following way:
1 Issue transform and clip based on localSVGTransform;
2 Call BlockFlowPainter::paint with zero LayoutPoint()
3 BlockFlowPainter::paint uses the object's location() as the actual
  paint offset.

The above painting method also required us to generate the same paint
properties in PaintPropertyTreeBuilder.

This CL change painting of LayoutSVGForiegnObject in a new way:
1 Issue transform and clip based on localToSVGParentTransform which
  includes the viewport offset;
2 Call BlockFlowPainter::paint with -location() as the paint offset;
3 BlockFlowPainter::paint then add the object's location() to the
  paint offset which results a zero paint offset.

With the new method, LayoutSVGForeignObject behaves more like a normal
SVG object so we can remove some special handling of it.

BUG=666416

x
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
Cr-Commit-Position: refs/heads/master@{#433080}
==========

[commit-bot: I haz the power, 2016-11-18 03:56:58]

Patchset 2 (id:??) landed as
https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
Cr-Commit-Position: refs/heads/master@{#433080}

[Xianzhu, 2016-11-20 02:13:23]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2513293002/ by wangxianzhu@chromium.org.

The reason for reverting is: It is incorrect to treat the HTML viewport defined
by a LayoutSVGForeignObject
as the "local SVG coordinate space", because it's not the space that the local
svg
transform, clip path and filters apply. This CL is wrong because it treats the
wrong LayoutSVGForeignObject::localToParentSVGTransform() as correct and used a
wrong way
to remedy that. This CL breaks clip path on foreignObject because the clip path
is
applied in wrong space.
.