Avoid special handling of LayoutSVGForeignObject about its paint offset

third_party/WebKit/Source/core/paint/ObjectPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/ObjectPainter.h"
 
 #include "core/layout/LayoutBlock.h"
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutObject.h"
 #include "core/layout/LayoutTheme.h"
@@ skipping 681 matching lines @@
   m_layoutObject.paint(info, paintOffset);
   info.phase = PaintPhaseOutline;
   m_layoutObject.paint(info, paintOffset);
 }
 
 #if DCHECK_IS_ON()
 void ObjectPainter::doCheckPaintOffset(const PaintInfo& paintInfo,
                                        const LayoutPoint& paintOffset) {
   DCHECK(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
 
-  // TODO(pdr,wangxianzhu): Refactor to avoid the special treatment for SVGText,
-  // SVGInline, SVGInlineText and SVGForeignObject.
-  if (m_layoutObject.isSVG() && !m_layoutObject.isSVGRoot() &&
-      !m_layoutObject.isSVGForeignObject()) {
-    if (!m_layoutObject.isSVGInline() && !m_layoutObject.isSVGInlineText())
-      DCHECK(paintOffset == LayoutPoint());
+  // Actual paint offsets of SVGInline and SVGInlineText include location()
+  // of the containing SVGText, but PaintPropertyTreeBuilder doesn't output
+  // the paint offsets. TODO(wangxianzhu): Avoid the special treatment.
+  if (m_layoutObject.isSVGInline() || m_layoutObject.isSVGInlineText())
     return;
-  }
 
   // TODO(pdr): Let painter and paint property tree builder generate the same
   // paint offset for LayoutScrollbarPart. crbug.com/664249.
   if (m_layoutObject.isLayoutScrollbarPart())
     return;
 
   LayoutPoint adjustedPaintOffset = paintOffset;
-  if (m_layoutObject.isBox())
+  // TODO(wangxianzhu): Avoid the special treatment for SVGText.
+  if (m_layoutObject.isBox() && !m_layoutObject.isSVGText())
     adjustedPaintOffset += toLayoutBox(m_layoutObject).location();
-  DCHECK(m_layoutObject.previousPaintOffset() == adjustedPaintOffset);
+  DCHECK(m_layoutObject.previousPaintOffset() == adjustedPaintOffset)
+      << " Paint offset mismatch: " << m_layoutObject.debugName()
+      << " from PaintPropertyTreeBuilder: "
+      << m_layoutObject.previousPaintOffset().toString()
+      << " from painter: " << adjustedPaintOffset.toString();
 }
 #endif
 
 }  // namespace blink