Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2512463003: Mojo EDK: Correctly handle EMSGSIZE on Mac. (Closed)

Created:
4 years, 1 month ago by Sam McNally
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo EDK: Correctly handle EMSGSIZE on Mac. As the comment copy-pasted from the IPC::ChannelPosix states, on Mac EMSGSIZE may be returned when sending a message if there is insufficient buffer space for transmitted FDs. Currently, the channel implementation treats this as a fatal error; this CL changes it to a recoverable error. This also re-enables NewlibPackagedAppTest.SuccessfulLoad, which was failing on some bots due to this problem. BUG=660582 Committed: https://crrev.com/12a7f40d299651beb746bf316b0c6c93fa8083d5 Cr-Commit-Position: refs/heads/master@{#434058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_posix.cc View 1 chunk +19 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (16 generated)
Sam McNally
+rockot for //mojo +raymes for //chrome/test/ppapi
4 years, 1 month ago (2016-11-17 04:29:11 UTC) #10
raymes
lgtm
4 years, 1 month ago (2016-11-20 23:21:36 UTC) #15
Sam McNally
rockot: ping
4 years, 1 month ago (2016-11-22 22:47:27 UTC) #16
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-22 22:49:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512463003/1
4 years, 1 month ago (2016-11-22 23:00:26 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-23 01:10:22 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 01:14:35 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12a7f40d299651beb746bf316b0c6c93fa8083d5
Cr-Commit-Position: refs/heads/master@{#434058}

Powered by Google App Engine
This is Rietveld 408576698