Remove IPC::BrokerableAttachment.

Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448
Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Committed: https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d
Cr-Original-Commit-Position: refs/heads/master@{#432153}
Cr-Commit-Position: refs/heads/master@{#434099}

[Sam McNally, 2016-11-11 03:13:22]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 03:13:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 03:23:21]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sam McNally, 2016-11-11 03:25:39]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 03:26:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-11 03:27:39]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-11-11 03:29:07]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[commit-bot: I haz the power, 2016-11-11 03:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 03:32:45]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Sam McNally, 2016-11-11 03:43:54]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 03:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 04:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 04:13:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-11-11 04:26:19]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 04:26:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 05:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 05:41:26]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-13 23:29:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-13 23:29:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-13 23:48:35]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-11-13 23:48:37]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-11-13 23:48:40]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-11-13 23:48:44]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-11-14 01:00:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 01:01:00]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-14 02:45:42]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 02:45:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-14 03:59:13]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-11-14 04:00:15]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org

[commit-bot: I haz the power, 2016-11-14 05:25:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 05:25:06]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-11-14 20:40:10]

lgtm

[Sam McNally, 2016-11-14 22:57:13]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, mseaborn@chromium.org, raymes@chromium.org

[Sam McNally, 2016-11-14 22:57:14]

+dcheng for //base

+mseaborn for //components/nacl

+raymes for //ppapi

[Mark Seaborn, 2016-11-14 23:44:42]

On 2016/11/14 22:57:14, Sam McNally wrote:
> +mseaborn for //components/nacl

LGTM for that.

[raymes, 2016-11-14 23:45:33]

rs lgtm

[dcheng, 2016-11-15 04:47:29]

base lgtm

+erikchen FYI

[Sam McNally, 2016-11-15 06:29:25]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-15 06:29:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 07:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 07:51:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sam McNally, 2016-11-15 09:04:45]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-15 09:05:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 09:47:22]

Committed patchset #1 (id:120001)

[commit-bot: I haz the power, 2016-11-15 09:49:06]

Description was changed from

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448
==========

to

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Cr-Commit-Position: refs/heads/master@{#432153}
==========

[commit-bot: I haz the power, 2016-11-15 09:49:07]

Patchset 1 (id:??) landed as
https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Cr-Commit-Position: refs/heads/master@{#432153}

[erikchen, 2016-11-15 18:08:03]

erikchen@chromium.org changed reviewers:
+ erikchen@chromium.org

[erikchen, 2016-11-15 18:08:04]

awesome, thanks!

[horo, 2016-11-16 01:44:32]

A revert of this CL (patchset #1 id:120001) has been created in
https://codereview.chromium.org/2504063002/ by horo@chromium.org.

The reason for reverting is: Caused crash in
NewlibPackagedAppTest.SuccessfulLoad browser_tests.

See http://crbug.com/665678#c1

BUG=665678.

[Sam McNally, 2016-11-16 03:10:08]

Description was changed from

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Cr-Commit-Position: refs/heads/master@{#432153}
==========

to

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Cr-Commit-Position: refs/heads/master@{#432153}
==========

[Sam McNally, 2016-11-16 23:56:10]

Patchset #2 (id:140001) has been deleted

[Sam McNally, 2016-11-16 23:56:13]

Patchset #3 (id:180001) has been deleted

[Sam McNally, 2016-11-16 23:56:14]

Patchset #2 (id:160001) has been deleted

[Sam McNally, 2016-11-16 23:56:17]

Patchset #2 (id:200001) has been deleted

[Sam McNally, 2016-11-16 23:57:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 23:58:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:00:48]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2016-11-17 04:28:26]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 04:29:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:32:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-11-17 08:34:16]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 08:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 09:21:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 09:21:26]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-23 00:42:20]

Patchset #4 (id:250001) has been deleted

[Sam McNally, 2016-11-23 01:37:47]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-23 01:37:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org, rockot@chromium.org, raymes@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2494943002/#ps230001
(title: "extra test output")

[commit-bot: I haz the power, 2016-11-23 01:38:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 03:17:41]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1479865067757840,
"parent_rev": "54f75d3d046813ddf818f28ee92ac30b2b90c357", "commit_rev":
"6cb60e10501f11ef34eae724919cc8ac8618452d"}

[commit-bot: I haz the power, 2016-11-23 03:18:12]

Description was changed from

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Cr-Commit-Position: refs/heads/master@{#432153}
==========

to

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Cr-Commit-Position: refs/heads/master@{#432153}
==========

[commit-bot: I haz the power, 2016-11-23 03:18:14]

Committed patchset #3 (id:230001)

[commit-bot: I haz the power, 2016-11-23 03:21:22]

Description was changed from

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Cr-Commit-Position: refs/heads/master@{#432153}
==========

to

==========
Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG=659448

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Committed: https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d
Cr-Original-Commit-Position: refs/heads/master@{#432153}
Cr-Commit-Position: refs/heads/master@{#434099}
==========

[commit-bot: I haz the power, 2016-11-23 03:21:23]

Patchset 3 (id:??) landed as
https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d
Cr-Commit-Position: refs/heads/master@{#434099}