Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2512433002: Upgrade gvr static lib and common_library.aar to support VrCore 1.2 (Closed)

Created:
4 years, 1 month ago by bshe
Modified:
4 years, 1 month ago
Reviewers:
bajones
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upgrade gvr static lib and common_library.aar to support VrCore 1.2 VrCore 1.2.0 is the latest public available version. Our static library should work with it. BUG=644785 Committed: https://crrev.com/2dfc644c2f70e2964c9cde48fcb577442aac50c1 Cr-Commit-Position: refs/heads/master@{#432591}

Patch Set 1 #

Patch Set 2 : proper arm64 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/gvr-android-sdk/common_library.aar.sha1 View 1 chunk +1 line, -1 line 1 comment Download
M third_party/gvr-android-sdk/libgvr_shim_static_arm.a.sha1 View 1 chunk +1 line, -1 line 1 comment Download
M third_party/gvr-android-sdk/libgvr_shim_static_arm64.a.sha1 View 1 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
bshe
Hi Brandon. Can you please take a look?
4 years, 1 month ago (2016-11-16 19:15:35 UTC) #7
bajones
LGTM with comments. https://codereview.chromium.org/2512433002/diff/20001/third_party/gvr-android-sdk/common_library.aar.sha1 File third_party/gvr-android-sdk/common_library.aar.sha1 (right): https://codereview.chromium.org/2512433002/diff/20001/third_party/gvr-android-sdk/common_library.aar.sha1#newcode1 third_party/gvr-android-sdk/common_library.aar.sha1:1: fc53a744c3b930eb2437fdab1492809befccf5ef Hm... too many 'f's in ...
4 years, 1 month ago (2016-11-16 19:21:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512433002/20001
4 years, 1 month ago (2016-11-16 19:23:17 UTC) #10
bshe
On 2016/11/16 19:21:09, bajones wrote: > LGTM with comments. > > https://codereview.chromium.org/2512433002/diff/20001/third_party/gvr-android-sdk/common_library.aar.sha1 > File third_party/gvr-android-sdk/common_library.aar.sha1 ...
4 years, 1 month ago (2016-11-16 19:25:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 19:35:44 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 19:53:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2dfc644c2f70e2964c9cde48fcb577442aac50c1
Cr-Commit-Position: refs/heads/master@{#432591}

Powered by Google App Engine
This is Rietveld 408576698