|
|
DescriptionEnable Android WebVR for arm & arm64
BUG=644785
Committed: https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898
Cr-Commit-Position: refs/heads/master@{#432489}
Patch Set 1 #Patch Set 2 : fix unit tests crash. Not sure why it didn't fail on debug build #Patch Set 3 : Proper fix #Patch Set 4 : Rebase #Patch Set 5 : rebase #Messages
Total messages: 29 (22 generated)
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bshe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
bshe@chromium.org changed reviewers: + agrieve@chromium.org
Hi Andrew. Do you mind to take a look at this? Thanks.
Description was changed from ========== Enable WebVR for non component build BUG=644785 ========== to ========== Enable WebVR for all arm and arm64 configurations. BUG=644785 ==========
Description was changed from ========== Enable WebVR for all arm and arm64 configurations. BUG=644785 ========== to ========== Enable Android WebVR for arm & arm64 BUG=644785 ==========
On 2016/11/15 21:35:20, bshe wrote: > Hi Andrew. Do you mind to take a look at this? Thanks. lgtm
The CQ bit was checked by bshe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable Android WebVR for arm & arm64 BUG=644785 ========== to ========== Enable Android WebVR for arm & arm64 BUG=644785 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Enable Android WebVR for arm & arm64 BUG=644785 ========== to ========== Enable Android WebVR for arm & arm64 BUG=644785 Committed: https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898 Cr-Commit-Position: refs/heads/master@{#432489} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898 Cr-Commit-Position: refs/heads/master@{#432489}
Message was sent while issue was closed.
On 2016/11/16 15:17:42, commit-bot: I haz the power wrote: > Patchset 5 (id:??) landed as > https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898 > Cr-Commit-Position: refs/heads/master@{#432489} Size graph results are in. This increased native code by 160kb, but increase dex size by 226kb! Total increase of 386kb for ChromeModern.apk. This seems more than expected, no? Can we revert while you investigate?
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2505963003/ by agrieve@chromium.org. The reason for reverting is: Reverting until dex size growth is understood.. |