Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2502643002: Enable WebVR for non component build (Closed)

Created:
4 years, 1 month ago by bshe
Modified:
4 years, 1 month ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Android WebVR for arm & arm64 BUG=644785 Committed: https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898 Cr-Commit-Position: refs/heads/master@{#432489}

Patch Set 1 #

Patch Set 2 : fix unit tests crash. Not sure why it didn't fail on debug build #

Patch Set 3 : Proper fix #

Patch Set 4 : Rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/config/features.gni View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (22 generated)
bshe
Hi Andrew. Do you mind to take a look at this? Thanks.
4 years, 1 month ago (2016-11-15 21:35:20 UTC) #18
agrieve
On 2016/11/15 21:35:20, bshe wrote: > Hi Andrew. Do you mind to take a look ...
4 years, 1 month ago (2016-11-16 15:04:00 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502643002/80001
4 years, 1 month ago (2016-11-16 15:09:29 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-16 15:14:03 UTC) #25
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898 Cr-Commit-Position: refs/heads/master@{#432489}
4 years, 1 month ago (2016-11-16 15:17:42 UTC) #27
agrieve
On 2016/11/16 15:17:42, commit-bot: I haz the power wrote: > Patchset 5 (id:??) landed as ...
4 years, 1 month ago (2016-11-16 19:56:49 UTC) #28
agrieve
4 years, 1 month ago (2016-11-16 20:10:05 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2505963003/ by agrieve@chromium.org.

The reason for reverting is: Reverting until dex size growth is understood..

Powered by Google App Engine
This is Rietveld 408576698