Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2512393002: ChromeOS OOBE: switch from iron-dropdown to <select>. (Closed)

Created:
4 years, 1 month ago by Alexander Alekseev
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: switch from iron-dropdown to <select>. To fix several issues with polymer dropdown menu by switching to native select. BUG=604119, 663267 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2502773003 Cr-Commit-Position: refs/heads/master@{#433137} (cherry picked from commit 076cf8a29b5dc4d850e221c2ed5d7b2d9d0a3e3e) Committed: https://chromium.googlesource.com/chromium/src/+/b597dbfa654aaad2f042294d943f8cae8fb765a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -200 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css View 1 chunk +5 lines, -30 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html View 1 chunk +7 lines, -42 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js View 1 chunk +13 lines, -46 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/display.html View 2 chunks +2 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/images/arrow_down.svg View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_apnlist.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 2 chunks +2 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/md_select_css.html View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/import_data_dialog.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/media_picker.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 chunk +2 lines, -1 line 0 comments Download
A + ui/webui/resources/html/md_select_css.html View 2 chunks +3 lines, -2 lines 0 comments Download
A + ui/webui/resources/images/arrow_down.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexander Alekseev
4 years, 1 month ago (2016-11-19 08:23:17 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b597dbfa654aaad2f042294d943f8cae8fb765a0.

Powered by Google App Engine
This is Rietveld 408576698