ChromeOS OOBE: switch from iron-dropdown to <select>.

ChromeOS OOBE: switch from iron-dropdown to <select>.

To fix several issues with polymer dropdown menu by switching to native select.

BUG=604119, 663267
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/076cf8a29b5dc4d850e221c2ed5d7b2d9d0a3e3e
Cr-Commit-Position: refs/heads/master@{#433137}

[Alexander Alekseev, 2016-11-15 05:53:08]

Description was changed from

==========
ChromeOS OOBE: switch from iron-dropdown to <select>.

To fix several issues with polymer dropdown menu by switching to native select.

BUG=604119,663267
==========

to

==========
ChromeOS OOBE: switch from iron-dropdown to <select>.

To fix several issues with polymer dropdown menu by switching to native select.

BUG=604119,663267
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2016-11-15 05:53:37]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 05:53:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-11-15 05:53:57]

alemate@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Alexander Alekseev, 2016-11-15 05:53:57]

Please review.

[commit-bot: I haz the power, 2016-11-15 08:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 08:13:18]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-11-16 01:59:01]

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:6: font-family:
Roboto, Sans-Serif;
nit: lowercase for generic fonts (sans-serif)

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:21: select {
if this is basically the same as md_select_css.html (and it probably should be),
can you use that? Would require moving it int ui/webui/cr_elements.

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js (right):

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js:42: id2Item_: [],
spell out numbers. and can you provide a more specific @type?

should this be a Map instead?

[Alexander Alekseev, 2016-11-16 07:10:59]

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:6: font-family:
Roboto, Sans-Serif;
On 2016/11/16 01:59:01, michaelpg wrote:
> nit: lowercase for generic fonts (sans-serif)

Done.

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:21: select {
On 2016/11/16 01:59:01, michaelpg wrote:
> if this is basically the same as md_select_css.html (and it probably should
be),
> can you use that? Would require moving it int ui/webui/cr_elements.

It turns out that this would require a lot of changes.
md_select_css.html carries a link to /settings_vars_css.html which has to be
manually included in all files that referenced original md_select_css.html .

Than, it requires some special initialization, which I did not found. And its
container is different.

So  I tried it, but it didn't work.

Probably we could once create md-select element and use it instead of plain
select with md-select class styling, but it doesn't seem to be easy.

So let's leave this as it is now.

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js (right):

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js:42: id2Item_: [],
On 2016/11/16 01:59:01, michaelpg wrote:
> spell out numbers. and can you provide a more specific @type?
> 
> should this be a Map instead?

Done.

[michaelpg, 2016-11-16 07:23:39]

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:21: select {
hrm, no it shouldn't be that complicated. So it should take a lot less code than
adding a copy of it here would. If you need to override some parts of the style
you can still do that here.

On 2016/11/16 07:10:59, Alexander Alekseev wrote:
> On 2016/11/16 01:59:01, michaelpg wrote:
> > if this is basically the same as md_select_css.html (and it probably should
> be),
> > can you use that? Would require moving it int ui/webui/cr_elements.
> 
> It turns out that this would require a lot of changes.
> md_select_css.html carries a link to /settings_vars_css.html which has to be
> manually included in all files that referenced original md_select_css.html .

Actually, AFAICT, md_select_css.html actually uses no external variables aside
from paper-styles/color.html, so you should be able to replace the
"/shared_vars_css.html" import in md_select_css.html with that Polymer
paper-styles/color.html file.

Not sure what "manually" means. Does OOBE inline HTML imports or something?
Other OOBE resources already import paper-styles/color.html, and it should be
de-duped by the browser.

> 
> Than, it requires some special initialization, which I did not found. And its
> container is different.

Looks like it just requires being wrapped in <div class="md-select-wrapper> and
having the md-select-underline <span>, which is already the structure you've
copied in oobe_i18n_dropdown.html, e.g.:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/intern...

> 
> So  I tried it, but it didn't work.
> 
> Probably we could once create md-select element and use it instead of plain
> select with md-select class styling, but it doesn't seem to be easy.
> 
> So let's leave this as it is now.

[Alexander Alekseev, 2016-11-16 07:40:30]

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):

https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:21: select {
On 2016/11/16 07:23:39, michaelpg wrote:
> hrm, no it shouldn't be that complicated. So it should take a lot less code
than
> adding a copy of it here would. If you need to override some parts of the
style
> you can still do that here.
> 
> On 2016/11/16 07:10:59, Alexander Alekseev wrote:
> > On 2016/11/16 01:59:01, michaelpg wrote:
> > > if this is basically the same as md_select_css.html (and it probably
should
> > be),
> > > can you use that? Would require moving it int ui/webui/cr_elements.
> > 
> > It turns out that this would require a lot of changes.
> > md_select_css.html carries a link to /settings_vars_css.html which has to be
> > manually included in all files that referenced original md_select_css.html .
> 
> Actually, AFAICT, md_select_css.html actually uses no external variables aside
> from paper-styles/color.html, so you should be able to replace the
> "/shared_vars_css.html" import in md_select_css.html with that Polymer
> paper-styles/color.html file.
> 
> Not sure what "manually" means. Does OOBE inline HTML imports or something?

md_select_css.html includes "/shared_vars_css.html" so "/shared_vars_css.html"
becomes available to all files that include md_select_css.html. This way it
looks like these files also have to be modified if md_select_css.html will not
include that file.

Yes, OOBE mostly inlines HTML. I tried to link (not inline) md_select_css.html
into OOBE, it becomes available, but ".md-select" CSS selector didn't work. Even
though md_select_css.html was loaded.

> Other OOBE resources already import paper-styles/color.html, and it should be
> de-duped by the browser.
> 
> > 
> > Than, it requires some special initialization, which I did not found. And
its
> > container is different.
> 
> Looks like it just requires being wrapped in <div class="md-select-wrapper>
and
> having the md-select-underline <span>, which is already the structure you've
> copied in oobe_i18n_dropdown.html, e.g.:
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/intern...

The problem is that CSS selector ".md-select" doesn't work and style is not
applied.

> > So  I tried it, but it didn't work.
> > 
> > Probably we could once create md-select element and use it instead of plain
> > select with md-select class styling, but it doesn't seem to be easy.
> > 
> > So let's leave this as it is now.
>

[michaelpg, 2016-11-16 21:18:53]

On 2016/11/16 07:40:30, Alexander Alekseev wrote:
>
https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css (right):
> 
>
https://codereview.chromium.org/2502773003/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css:21: select {
> On 2016/11/16 07:23:39, michaelpg wrote:
> > hrm, no it shouldn't be that complicated. So it should take a lot less code
> than
> > adding a copy of it here would. If you need to override some parts of the
> style
> > you can still do that here.
> > 
> > On 2016/11/16 07:10:59, Alexander Alekseev wrote:
> > > On 2016/11/16 01:59:01, michaelpg wrote:
> > > > if this is basically the same as md_select_css.html (and it probably
> should
> > > be),
> > > > can you use that? Would require moving it int ui/webui/cr_elements.
> > > 
> > > It turns out that this would require a lot of changes.
> > > md_select_css.html carries a link to /settings_vars_css.html which has to
be
> > > manually included in all files that referenced original md_select_css.html
.
> > 
> > Actually, AFAICT, md_select_css.html actually uses no external variables
aside
> > from paper-styles/color.html, so you should be able to replace the
> > "/shared_vars_css.html" import in md_select_css.html with that Polymer
> > paper-styles/color.html file.
> > 
> > Not sure what "manually" means. Does OOBE inline HTML imports or something?
> 
> md_select_css.html includes "/shared_vars_css.html" so "/shared_vars_css.html"
> becomes available to all files that include md_select_css.html. This way it
> looks like these files also have to be modified if md_select_css.html will not
> include that file.
> 
> Yes, OOBE mostly inlines HTML. I tried to link (not inline) md_select_css.html
> into OOBE, it becomes available, but ".md-select" CSS selector didn't work.
Even
> though md_select_css.html was loaded.
> 
> > Other OOBE resources already import paper-styles/color.html, and it should
be
> > de-duped by the browser.
> > 
> > > 
> > > Than, it requires some special initialization, which I did not found. And
> its
> > > container is different.
> > 
> > Looks like it just requires being wrapped in <div class="md-select-wrapper>
> and
> > having the md-select-underline <span>, which is already the structure you've
> > copied in oobe_i18n_dropdown.html, e.g.:
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/intern...
> 
> The problem is that CSS selector ".md-select" doesn't work and style is not
> applied.
> 
> > > So  I tried it, but it didn't work.
> > > 
> > > Probably we could once create md-select element and use it instead of
plain
> > > select with md-select class styling, but it doesn't seem to be easy.
> > > 
> > > So let's leave this as it is now.
> >


Oh, you need to include the custom style in oobe_i18n_dropdown.html; just add:

    <style include="md-select"></style>

to the template. See
https://www.polymer-project.org/1.0/docs/devguide/styling#style-modules

[Alexander Alekseev, 2016-11-16 23:17:36]

On 2016/11/16 21:18:53, michaelpg wrote:

> 
> Oh, you need to include the custom style in oobe_i18n_dropdown.html; just add:
> 
>     <style include="md-select"></style>
> 
> to the template. See
> https://www.polymer-project.org/1.0/docs/devguide/styling#style-modules

Done.

[Alexander Alekseev, 2016-11-16 23:17:50]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 23:18:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 00:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 00:57:10]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Alexander Alekseev, 2016-11-17 01:12:54]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 01:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-11-17 01:58:15]

awesome! Just some import comments.

https://codereview.chromium.org/2502773003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/2502773003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/appearance_page/appearance_page.html:12: <link
rel="import" href="/settings_vars_css.html">
For all settings files: alphabetize. "/settings_vars_css.html" goes below
"/settings_shared_css.html".

https://codereview.chromium.org/2502773003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/appearance_page/appearance_page.html:13: <link
rel="import" href="chrome://resources/html/md_select_css.html">
For all settings files:
nit: when sorting, chrome:// URLs go above the others, e.g. this one goes on the
2nd line now.

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/htm...
File ui/webui/resources/html/md_select_css.html (right):

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/htm...
ui/webui/resources/html/md_select_css.html:1: <link rel="import"
href="chrome://resources/cr_elements/shared_vars_css.html">
Could be wrong, but I don't think we have to depend on this file, so let's not.

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/web...
File ui/webui/resources/webui_resources.grd (right):

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/web...
ui/webui/resources/webui_resources.grd:319: type="chrome_html"
flattenhtml="true" />
do we really need flattenhtml?

[Alexander Alekseev, 2016-11-17 02:25:09]

https://codereview.chromium.org/2502773003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/2502773003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/appearance_page/appearance_page.html:12: <link
rel="import" href="/settings_vars_css.html">
On 2016/11/17 01:58:15, michaelpg wrote:
> For all settings files: alphabetize. "/settings_vars_css.html" goes below
> "/settings_shared_css.html".

Done.

https://codereview.chromium.org/2502773003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/appearance_page/appearance_page.html:13: <link
rel="import" href="chrome://resources/html/md_select_css.html">
On 2016/11/17 01:58:15, michaelpg wrote:
> For all settings files:
> nit: when sorting, chrome:// URLs go above the others, e.g. this one goes on
the
> 2nd line now.

Done.

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/htm...
File ui/webui/resources/html/md_select_css.html (right):

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/htm...
ui/webui/resources/html/md_select_css.html:1: <link rel="import"
href="chrome://resources/cr_elements/shared_vars_css.html">
On 2016/11/17 01:58:15, michaelpg wrote:
> Could be wrong, but I don't think we have to depend on this file, so let's
not.

Done.

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/web...
File ui/webui/resources/webui_resources.grd (right):

https://codereview.chromium.org/2502773003/diff/100001/ui/webui/resources/web...
ui/webui/resources/webui_resources.grd:319: type="chrome_html"
flattenhtml="true" />
On 2016/11/17 01:58:15, michaelpg wrote:
> do we really need flattenhtml?

Removed.

[Alexander Alekseev, 2016-11-17 02:25:50]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 02:27:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 03:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:11:26]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Alexander Alekseev, 2016-11-17 03:17:46]

Michael, do you have any idea why Mac tests are failing?

[michaelpg, 2016-11-17 21:55:18]

On 2016/11/17 03:17:46, Alexander Alekseev wrote:
> Michael, do you have any idea why Mac tests are failing?

[29036:37635:1116/185602:FATAL:shared_resources_data_source.cc(91)] Check
failed: -1 != idr (-1 vs. -1) path: images/arrow_down.svg

Looks like part of the .grd didn't get copied over:
    flattenhtml="true"

so add that (or, better, just preprocess="true) to the webui_resources.grd
structure so the svg gets inlined.

[Alexander Alekseev, 2016-11-17 22:28:42]

On 2016/11/17 21:55:18, michaelpg wrote:
> On 2016/11/17 03:17:46, Alexander Alekseev wrote:
> > Michael, do you have any idea why Mac tests are failing?
> 
> [29036:37635:1116/185602:FATAL:shared_resources_data_source.cc(91)] Check
> failed: -1 != idr (-1 vs. -1) path: images/arrow_down.svg
> 
> Looks like part of the .grd didn't get copied over:
>     flattenhtml="true"
> 
> so add that (or, better, just preprocess="true) to the webui_resources.grd
> structure so the svg gets inlined.

Done.

[Alexander Alekseev, 2016-11-17 22:28:51]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[Alexander Alekseev, 2016-11-17 22:30:30]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 22:30:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 22:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:40:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Alexander Alekseev, 2016-11-17 23:02:44]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 23:05:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:34:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alexander Alekseev, 2016-11-18 00:50:46]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 00:52:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 01:42:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 01:42:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alexander Alekseev, 2016-11-18 02:47:01]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 02:49:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 04:11:11]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-11-18 06:03:50]

lgtm

[Alexander Alekseev, 2016-11-18 06:45:10]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-11-18 06:45:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 06:50:44]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-11-18 06:53:03]

Description was changed from

==========
ChromeOS OOBE: switch from iron-dropdown to <select>.

To fix several issues with polymer dropdown menu by switching to native select.

BUG=604119,663267
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: switch from iron-dropdown to <select>.

To fix several issues with polymer dropdown menu by switching to native select.

BUG=604119,663267
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/076cf8a29b5dc4d850e221c2ed5d7b2d9d0a3e3e
Cr-Commit-Position: refs/heads/master@{#433137}
==========

[commit-bot: I haz the power, 2016-11-18 06:53:05]

Patchset 12 (id:??) landed as
https://crrev.com/076cf8a29b5dc4d850e221c2ed5d7b2d9d0a3e3e
Cr-Commit-Position: refs/heads/master@{#433137}