Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2512323004: Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. (patchset #10 id:180001 of https://codereview.chromium.org/2471883003/ ) Reason for revert: Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/7114 Original issue's description: > [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. > > Add support for WebAssembly.Memory objects to be simultaneously referenced by multiple Instance objects. GrowingMemory should maintain a consistent view of memory across instances. > - Store a link to instances that share WebAssembly.Memory in the WasmMemoryObject, updated on instantiate. > - Implement WasmInstanceWrapper as a wrapper around the instance object to keep track of previous/next instances, instance object is stored as a WeakCell that can be garbage collected. > - MemoryInstanceFinalizer maintains a valid list of instances when an instance is garbage collected. > - Refactor GrowInstanceMemory to GrowMemoryBuffer that allocates a new buffer, and UncheckedUpdateInstanceMemory that updates memory references for an instance. > > R=titzer@chromium.org, mtrofin@chromium.org, bradnelson@chromium.org > > Committed: https://crrev.com/30ef8e33f3a199a27ca8512bcee314c9522d03f6 > Cr-Commit-Position: refs/heads/master@{#41121} TBR=bradnelson@chromium.org,mtrofin@chromium.org,titzer@chromium.org,gdeepti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/682f6500ee040e6369fb7936e6bc53db49a135d0 Cr-Commit-Position: refs/heads/master@{#41122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -541 lines) Patch
M src/runtime/runtime-wasm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-js.cc View 4 chunks +29 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +2 lines, -10 lines 0 comments Download
M src/wasm/wasm-module.cc View 9 chunks +62 lines, -163 lines 0 comments Download
M src/wasm/wasm-objects.h View 5 chunks +3 lines, -63 lines 0 comments Download
M src/wasm/wasm-objects.cc View 4 chunks +4 lines, -55 lines 0 comments Download
M test/mjsunit/wasm/import-memory.js View 2 chunks +1 line, -138 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/wasm/memory-instance-validation.js View 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects.
4 years, 1 month ago (2016-11-19 13:39:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512323004/1
4 years, 1 month ago (2016-11-19 13:39:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 13:39:23 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 13:39:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/682f6500ee040e6369fb7936e6bc53db49a135d0
Cr-Commit-Position: refs/heads/master@{#41122}

Powered by Google App Engine
This is Rietveld 408576698