Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/wasm/wasm-js.cc

Issue 2512323004: Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-wasm.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-js.cc
diff --git a/src/wasm/wasm-js.cc b/src/wasm/wasm-js.cc
index 80c7ad1be0959280ed7ccca347a4ef0f65bce9c5..b95ab9a20f59544562c83e4040cf6d8654b9a5a2 100644
--- a/src/wasm/wasm-js.cc
+++ b/src/wasm/wasm-js.cc
@@ -28,6 +28,12 @@
namespace v8 {
+enum WasmMemoryObjectData {
+ kWasmMemoryBuffer,
+ kWasmMemoryMaximum,
+ kWasmMemoryInstanceObject
+};
+
namespace {
i::Handle<i::String> v8_str(i::Isolate* isolate, const char* str) {
return isolate->factory()->NewStringFromAsciiChecked(str);
@@ -224,7 +230,6 @@
i_isolate);
} else {
thrower.TypeError("Argument 2 must be a WebAssembly.Memory");
- return;
}
}
i::MaybeHandle<i::JSObject> instance =
@@ -525,15 +530,31 @@
uint32_t delta = args[0]->Uint32Value(context).FromJust();
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
- i::Handle<i::Object> receiver =
- i::Handle<i::Object>::cast(Utils::OpenHandle(*args.This()));
- int32_t ret = i::wasm::GrowWebAssemblyMemory(i_isolate, receiver, delta);
+ i::Handle<i::JSObject> receiver =
+ i::Handle<i::JSObject>::cast(Utils::OpenHandle(*args.This()));
+ i::Handle<i::Object> instance_object(
+ receiver->GetInternalField(kWasmMemoryInstanceObject), i_isolate);
+ i::Handle<i::WasmInstanceObject> instance(
+ i::Handle<i::WasmInstanceObject>::cast(instance_object));
+
+ // TODO(gdeepti) Implement growing memory when shared by different
+ // instances.
+ int32_t ret = internal::wasm::GrowInstanceMemory(i_isolate, instance, delta);
if (ret == -1) {
v8::Local<v8::Value> e = v8::Exception::Error(
v8_str(isolate, "Unable to grow instance memory."));
isolate->ThrowException(e);
return;
}
+ i::MaybeHandle<i::JSArrayBuffer> buffer =
+ internal::wasm::GetInstanceMemory(i_isolate, instance);
+ if (buffer.is_null()) {
+ v8::Local<v8::Value> e = v8::Exception::Error(
+ v8_str(isolate, "WebAssembly.Memory buffer object not set."));
+ isolate->ThrowException(e);
+ return;
+ }
+ receiver->SetInternalField(kWasmMemoryBuffer, *buffer.ToHandleChecked());
v8::ReturnValue<v8::Value> return_value = args.GetReturnValue();
return_value.Set(ret);
}
@@ -549,9 +570,10 @@
return;
}
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
- i::Handle<i::WasmMemoryObject> receiver =
- i::Handle<i::WasmMemoryObject>::cast(Utils::OpenHandle(*args.This()));
- i::Handle<i::Object> buffer(receiver->get_buffer(), i_isolate);
+ i::Handle<i::JSObject> receiver =
+ i::Handle<i::JSObject>::cast(Utils::OpenHandle(*args.This()));
+ i::Handle<i::Object> buffer(receiver->GetInternalField(kWasmMemoryBuffer),
+ i_isolate);
DCHECK(buffer->IsJSArrayBuffer());
v8::ReturnValue<v8::Value> return_value = args.GetReturnValue();
return_value.Set(Utils::ToLocal(buffer));
« no previous file with comments | « src/runtime/runtime-wasm.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698