Add name, package_repo_resource and resource support to recipe scripts.

Add name, package_repo_resource and resource support to recipe scripts.

R=dnj@chromium.org, nodir@chromium.org
BUG=662586
Committed: https://github.com/luci/recipes-py/commit/a1c2338808c1a2a02d520f4078d21f766b43df5b

[nodir, 2016-11-18 22:42:25]

lgtm

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/config_types.py
File recipe_engine/config_types.py (right):

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/config_types....
recipe_engine/config_types.py:127: return 'RECIPE[%s].resources' %
self.recipe_name
shouldn't this be RECIPE_RESOURCES[%s] ?
what is RECIPE[%s]? path to the recipe without extension?

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/loader.py
File recipe_engine/loader.py (right):

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/loader.py#new...
recipe_engine/loader.py:59: return os.path.basename(self.path).split('.')[0]
os.path.splitext?

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/loader.py#new...
recipe_engine/loader.py:588: print recipe_script_path
left by mistake?

https://codereview.chromium.org/2512253002/diff/1/recipes/engine_tests/recipe...
File recipes/engine_tests/recipe_paths.py (right):

https://codereview.chromium.org/2512253002/diff/1/recipes/engine_tests/recipe...
recipes/engine_tests/recipe_paths.py:9: 'path',
sort?

[iannucci, 2016-11-19 00:00:57]

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/config_types.py
File recipe_engine/config_types.py (right):

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/config_types....
recipe_engine/config_types.py:127: return 'RECIPE[%s].resources' %
self.recipe_name
On 2016/11/18 22:42:25, nodir wrote:
> shouldn't this be RECIPE_RESOURCES[%s] ?
> what is RECIPE[%s]? path to the recipe without extension?

Discussed offline, don't see a better alternative :/

RECIPE_WITHOUT_EXTENSION[%s].resources just seems long :D

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/loader.py
File recipe_engine/loader.py (right):

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/loader.py#new...
recipe_engine/loader.py:59: return os.path.basename(self.path).split('.')[0]
On 2016/11/18 22:42:25, nodir wrote:
> os.path.splitext?

Done.

https://codereview.chromium.org/2512253002/diff/1/recipe_engine/loader.py#new...
recipe_engine/loader.py:588: print recipe_script_path
On 2016/11/18 22:42:25, nodir wrote:
> left by mistake?

Oops! 0:)

https://codereview.chromium.org/2512253002/diff/1/recipes/engine_tests/recipe...
File recipes/engine_tests/recipe_paths.py (right):

https://codereview.chromium.org/2512253002/diff/1/recipes/engine_tests/recipe...
recipes/engine_tests/recipe_paths.py:9: 'path',
On 2016/11/18 22:42:25, nodir wrote:
> sort?

Done.

[nodir, 2016-11-19 00:14:53]

lgtm

[iannucci, 2016-11-19 00:15:32]

forgot to publish comments

https://codereview.chromium.org/2512253002/diff/40001/recipe_engine/config_ty...
File recipe_engine/config_types.py (right):

https://codereview.chromium.org/2512253002/diff/40001/recipe_engine/config_ty...
recipe_engine/config_types.py:124: return
os.path.splitext(self.script_path)[0]+".resources" # pragma: no cover
this was a bug

https://codereview.chromium.org/2512253002/diff/40001/recipe_engine/loader.py
File recipe_engine/loader.py (right):

https://codereview.chromium.org/2512253002/diff/40001/recipe_engine/loader.py...
recipe_engine/loader.py:283: def scan_directory(path, predicate):
this was only used inside loop_over_recipes, so I moved it.

https://codereview.chromium.org/2512253002/diff/40001/recipe_engine/recipe_ap...
File recipe_engine/recipe_api.py (right):

https://codereview.chromium.org/2512253002/diff/40001/recipe_engine/recipe_ap...
recipe_engine/recipe_api.py:653: self.m = ModuleInjectionSite(self)
this is really dumb, but it's what caused the error you were seeing, nodir.

[iannucci, 2016-11-19 00:15:36]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:15:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:20:57]

Description was changed from

==========
Add name, package_repo_resource and resource support to recipe scripts.

R=dnj@chromium.org, nodir@chromium.org
BUG=662586
==========

to

==========
Add name, package_repo_resource and resource support to recipe scripts.

R=dnj@chromium.org, nodir@chromium.org
BUG=662586

Committed:
https://github.com/luci/recipes-py/commit/a1c2338808c1a2a02d520f4078d21f766b4...
==========

[commit-bot: I haz the power, 2016-11-19 00:20:58]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/a1c2338808c1a2a02d520f4078d21f766b4...