Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2512163002: Force re-layout of a float when we just became unfragmented. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force re-layout of a float when we just became unfragmented. We need to re-lay out a float if we cease to be fragmented, in order to remove any pagination struts that may previously have been set inside. This is an addition to https://codereview.chromium.org/2454083002 , which fixed something similar for regular in-flow blocks. Committed: https://crrev.com/f4fc4760300b690506395c9df26212388bb80e59 Cr-Commit-Position: refs/heads/master@{#433221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fragmentation/become-unfragmented-with-float.html View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-18 14:23:51 UTC) #4
eae
Nice test! LGTM
4 years, 1 month ago (2016-11-18 16:45:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512163002/1
4 years, 1 month ago (2016-11-18 16:46:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 17:05:15 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 17:08:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4fc4760300b690506395c9df26212388bb80e59
Cr-Commit-Position: refs/heads/master@{#433221}

Powered by Google App Engine
This is Rietveld 408576698