Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2454083002: Need a deep layout pass when becoming (un)fragmented. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Need a deep layout pass when becoming (un)fragmented. When an object ceases to be fragmented (e.g. when leaving print preview), there may be pagination struts that need to be removed. Therefore, we need to lay out all descendants of a block that ceased to establish a fragmentation context. Similarly, when becoming fragmented (e.g. when entering print preview), we need to go through every descendant. There may both be implicit and forced breaks to insert. BUG=658019 Committed: https://crrev.com/2cfe39f5654c3284b904f4e4e6ae5b08b6a4b5a7 Cr-Commit-Position: refs/heads/master@{#428062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/become-unfragmented-with-unbreakable-blocks.html View 1 chunk +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-27 15:05:15 UTC) #6
eae
LGTM
4 years, 1 month ago (2016-10-27 17:03:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454083002/1
4 years, 1 month ago (2016-10-27 17:04:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 17:10:07 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 17:31:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cfe39f5654c3284b904f4e4e6ae5b08b6a4b5a7
Cr-Commit-Position: refs/heads/master@{#428062}

Powered by Google App Engine
This is Rietveld 408576698