HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests.

net/server/http_server_unittest.cc

Index: net/server/http_server_unittest.cc
diff --git a/net/server/http_server_unittest.cc b/net/server/http_server_unittest.cc
index 87c35b198e7b3d42d385681aedc576a3766e09d0..e18600459da91f07d52402baaa3d781af147a83b 100644
--- a/net/server/http_server_unittest.cc
+++ b/net/server/http_server_unittest.cc
@@ -208,11 +208,23 @@ TEST_F(HttpServerTest, Request) {
   ASSERT_EQ("/test", GetRequest(0).path);
   ASSERT_EQ("", GetRequest(0).data);
   ASSERT_EQ(0u, GetRequest(0).headers.size());
+  ASSERT_EQ(HttpVersion(1, 1), GetRequest(0).http_version);
   ASSERT_TRUE(StartsWithASCII(GetRequest(0).peer.ToString(),
                               "127.0.0.1",
                               true));
 }
 
+TEST_F(HttpServerTest, InvalidHttpVersion) {

[byungchul, 2014/04/28 23:57:10]

This test should go http_util_unittests.cc

[gunsch, 2014/04/29 00:02:32]

No, this is about HttpServer replacing invalid headers with "HTTP/1.0" (same
thing HttpResponseHeaders does), which is not part of ParseVersion.

+  TestHttpClient client;
+  ASSERT_EQ(OK, client.ConnectAndWait(server_address_));
+  client.Send("GET /test HTTP//1\r\n\r\n");

[byungchul, 2014/04/28 23:57:10]

HTTP/1.0 in real world.

[gunsch, 2014/04/29 00:02:32]

HttpResponseHeadersTest has a test for replacing "HTTP/1//1" with "HTTP/1.0". I
think this is equivalent and reasonable, even if highly unlikely in "real
world".

+  ASSERT_TRUE(RunUntilRequestsReceived(1));
+  ASSERT_EQ("GET", GetRequest(0).method);
+  ASSERT_EQ("/test", GetRequest(0).path);
+  ASSERT_EQ("", GetRequest(0).data);
+  ASSERT_EQ(HttpVersion(1, 0), GetRequest(0).http_version);
+}
+
 TEST_F(HttpServerTest, RequestWithHeaders) {
   TestHttpClient client;
   ASSERT_EQ(OK, client.ConnectAndWait(server_address_));