HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests.

net/server/http_server_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
@@ skipping 190 matching lines @@
 
 TEST_F(HttpServerTest, Request) {
   TestHttpClient client;
   ASSERT_EQ(OK, client.ConnectAndWait(server_address_));
   client.Send("GET /test HTTP/1.1\r\n\r\n");
   ASSERT_TRUE(RunUntilRequestsReceived(1));
   ASSERT_EQ("GET", GetRequest(0).method);
   ASSERT_EQ("/test", GetRequest(0).path);
   ASSERT_EQ("", GetRequest(0).data);
   ASSERT_EQ(0u, GetRequest(0).headers.size());
+  ASSERT_EQ(HttpVersion(1, 1), GetRequest(0).http_version);
   ASSERT_TRUE(StartsWithASCII(GetRequest(0).peer.ToString(),
                               "127.0.0.1",
                               true));
 }
 
+TEST_F(HttpServerTest, InvalidHttpVersion) {

[byungchul, 2014/04/28 23:57:10]

This test should go http_util_unittests.cc

[gunsch, 2014/04/29 00:02:32]

No, this is about HttpServer replacing invalid headers with "HTTP/1.0" (same
thing HttpResponseHeaders does), which is not part of ParseVersion.

+  TestHttpClient client;
+  ASSERT_EQ(OK, client.ConnectAndWait(server_address_));
+  client.Send("GET /test HTTP//1\r\n\r\n");

[byungchul, 2014/04/28 23:57:10]

HTTP/1.0 in real world.

[gunsch, 2014/04/29 00:02:32]

HttpResponseHeadersTest has a test for replacing "HTTP/1//1" with "HTTP/1.0". I
think this is equivalent and reasonable, even if highly unlikely in "real
world".

+  ASSERT_TRUE(RunUntilRequestsReceived(1));
+  ASSERT_EQ("GET", GetRequest(0).method);
+  ASSERT_EQ("/test", GetRequest(0).path);
+  ASSERT_EQ("", GetRequest(0).data);
+  ASSERT_EQ(HttpVersion(1, 0), GetRequest(0).http_version);
+}
+
 TEST_F(HttpServerTest, RequestWithHeaders) {
   TestHttpClient client;
   ASSERT_EQ(OK, client.ConnectAndWait(server_address_));
   const char* kHeaders[][3] = {
       {"Header", ": ", "1"},
       {"HeaderWithNoWhitespace", ":", "1"},
       {"HeaderWithWhitespace", "   :  \t   ", "1 1 1 \t  "},
       {"HeaderWithColon", ": ", "1:1"},
       {"EmptyHeader", ":", ""},
       {"EmptyHeaderWithWhitespace", ":  \t  ", ""},
@@ skipping 167 matching lines @@
 
   ASSERT_EQ(client_connection_id, GetConnectionId(2));
   server_->Send200(client_connection_id, "Content for /test3", "text/plain");
   std::string response3;
   ASSERT_TRUE(client.Read(&response3));
   ASSERT_TRUE(StartsWithASCII(response3, "HTTP/1.1 200 OK", true));
   ASSERT_TRUE(EndsWith(response3, "Content for /test3", true));
 }
 
 }  // namespace net